r108570 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108569‎ | r108570 | r108571 >
Date:00:07, 11 January 2012
Author:rmoen
Status:ok
Tags:
Comment:
float left secondary filter checkboxes, add clearfix elements after labels
Modified paths:
  • /trunk/extensions/MoodBar/SpecialFeedbackDashboard.php (modified) (history)
  • /trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/SpecialFeedbackDashboard.php
@@ -112,7 +112,7 @@
113113 array( 'id' => 'fbd-filters-my-response', 'value' => '1', 'class' => 'fbd-filters-check' ) );
114114
115115 $myResponseFilter = $myResponseCheckbox. '<label for="fbd-filters-my-response" id="fbd-filters-type-my-response-label" class="fbd-filters-label">' .
116 - $myResponseMsg . '</label>';
 116+ $myResponseMsg . '</label><br class="fbd-clearfix" />';
117117 }
118118
119119 // Show unanswered filter
@@ -121,7 +121,7 @@
122122 array( 'id' => 'fbd-filters-show-unanswered', 'value' => '1', 'class' => 'fbd-filters-check' ) );
123123
124124 $showUnansweredFilter = $showUnansweredCheckbox . '<label for="fbd-filters-show-unanswered" id="fbd-filters-type-show-unanswered-label" class="fbd-filters-label">' .
125 - $showUnansweredMsg . '</label>';
 125+ $showUnansweredMsg . '</label><br class="fbd-clearfix" />';
126126
127127 $leaderBoardElement = self::buildLeaderBoardElement();
128128
Index: trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.css
@@ -36,6 +36,9 @@
3737 border: none;
3838 }
3939
 40+.fbd-filters-check {
 41+ float: left;
 42+}
4043 .fbd-filters-label {
4144 display: inline;
4245 margin: 0.5em 0 0 0;
@@ -123,7 +126,7 @@
124127 .fbd-tooltip-overlay-wrap {
125128 width: 285px;
126129 position: absolute;
127 - left: 7em;
 130+ left: 1em;
128131 top: 5.25em;
129132 background: #ff9933;
130133 padding: 2px;
@@ -487,4 +490,7 @@
488491 .red-bold {
489492 font-weight: bold;
490493 color: #CC0000;
 494+}
 495+.fbd-clearfix {
 496+ clear: both;
491497 }
\ No newline at end of file

Status & tagging log