r108554 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108553‎ | r108554 | r108555 >
Date:22:31, 10 January 2012
Author:kaldari
Status:ok
Tags:
Comment:
some more comments
Modified paths:
  • /trunk/extensions/CentralNotice/CentralNotice.db.php (modified) (history)
  • /trunk/extensions/CentralNotice/special/SpecialBannerAllocation.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/special/SpecialBannerAllocation.php
@@ -205,6 +205,13 @@
206206 $wgOut->addHTML( $htmlOut );
207207 }
208208
 209+ /**
 210+ * Generate the HTML for an allocation table
 211+ * @param $type string The title for the table
 212+ * @param $banners array The banners to list
 213+ * @param $weight integer The total weight of the banners
 214+ * @return HTML for the table
 215+ */
209216 function getTable( $type, $banners, $weight ) {
210217 global $wgLang;
211218
Index: trunk/extensions/CentralNotice/CentralNotice.db.php
@@ -411,6 +411,7 @@
412412
413413 /**
414414 * Return all of the available countries for geotargeting
 415+ * TODO: Move this out of CentralNoticeDB (or rename the class)
415416 * @param string $code The language code to return the country list in
416417 * @return array
417418 */

Status & tagging log