r108540 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108539‎ | r108540 | r108541 >
Date:20:01, 10 January 2012
Author:kaldari
Status:ok
Tags:
Comment:
slight increase in multi-selector size pending real fix to bug 32761
Modified paths:
  • /trunk/extensions/CentralNotice/special/SpecialCentralNotice.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/special/SpecialCentralNotice.php
@@ -1462,7 +1462,7 @@
14631463 $htmlOut = '';
14641464 if ( $this->editable ) {
14651465 $htmlOut .= Xml::tags( 'select',
1466 - array( 'multiple' => 'multiple', 'size' => 4, 'id' => 'project_languages[]', 'name' => 'project_languages[]' ),
 1466+ array( 'multiple' => 'multiple', 'size' => 6, 'id' => 'project_languages[]', 'name' => 'project_languages[]' ),
14671467 $options
14681468 );
14691469 $buttons = array();
@@ -1481,7 +1481,7 @@
14821482 $htmlOut .= Xml::tags( 'select',
14831483 array(
14841484 'multiple' => 'multiple',
1485 - 'size' => 4,
 1485+ 'size' => 6,
14861486 'id' => 'project_languages[]',
14871487 'name' => 'project_languages[]',
14881488 'disabled' => 'disabled'
@@ -1512,7 +1512,7 @@
15131513 $htmlOut = '';
15141514 if ( $this->editable ) {
15151515 $htmlOut .= Xml::tags( 'select',
1516 - array( 'multiple' => 'multiple', 'size' => 4, 'id' => 'projects[]', 'name' => 'projects[]' ),
 1516+ array( 'multiple' => 'multiple', 'size' => 5, 'id' => 'projects[]', 'name' => 'projects[]' ),
15171517 $options
15181518 );
15191519 $buttons = array();
@@ -1529,7 +1529,7 @@
15301530 $htmlOut .= Xml::tags( 'select',
15311531 array(
15321532 'multiple' => 'multiple',
1533 - 'size' => 4,
 1533+ 'size' => 5,
15341534 'id' => 'projects[]',
15351535 'name' => 'projects[]',
15361536 'disabled' => 'disabled'
@@ -1683,7 +1683,7 @@
16841684 $htmlOut .= Xml::tags( 'select',
16851685 array(
16861686 'multiple' => 'multiple',
1687 - 'size' => 5,
 1687+ 'size' => 6,
16881688 'id' => 'geo_countries[]',
16891689 'name' => 'geo_countries[]'
16901690 ),
@@ -1693,7 +1693,7 @@
16941694 $htmlOut .= Xml::tags( 'select',
16951695 array(
16961696 'multiple' => 'multiple',
1697 - 'size' => 5,
 1697+ 'size' => 6,
16981698 'id' => 'geo_countries[]',
16991699 'name' => 'geo_countries[]',
17001700 'disabled' => 'disabled'

Status & tagging log