r108527 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108526‎ | r108527 | r108528 >
Date:18:05, 10 January 2012
Author:aaron
Status:ok
Tags:
Comment:
Reverted r108502, r108504 per CR
Modified paths:
  • /trunk/phase3/includes/installer/MysqlUpdater.php (modified) (history)
  • /trunk/phase3/maintenance/archives/patch-drop_old_text_fields.sql (deleted) (history)
  • /trunk/phase3/maintenance/archives/patch-drop_old_text_indexes.sql (deleted) (history)

Diff [purge]

Index: trunk/phase3/maintenance/archives/patch-drop_old_text_indexes.sql
@@ -1,5 +0,0 @@
2 -DROP INDEX old_namespace ON /*_*/text;
3 -DROP INDEX old_timestamp ON /*_*/text;
4 -DROP INDEX name_title_timestamp ON /*_*/text;
5 -DROP INDEX user_timestamp ON /*_*/text;
6 -DROP INDEX usertext_timestamp ON /*_*/text;
\ No newline at end of file
Index: trunk/phase3/maintenance/archives/patch-drop_old_text_fields.sql
@@ -1,8 +0,0 @@
2 -ALTER TABLE /*_*/text DROP COLUMN old_namespace;
3 -ALTER TABLE /*_*/text DROP COLUMN old_title;
4 -ALTER TABLE /*_*/text DROP COLUMN old_comment;
5 -ALTER TABLE /*_*/text DROP COLUMN old_user;
6 -ALTER TABLE /*_*/text DROP COLUMN old_user_text;
7 -ALTER TABLE /*_*/text DROP COLUMN old_timestamp;
8 -ALTER TABLE /*_*/text DROP COLUMN old_minor_edit;
9 -ALTER TABLE /*_*/text DROP COLUMN inverse_timestamp;
\ No newline at end of file
Index: trunk/phase3/includes/installer/MysqlUpdater.php
@@ -192,8 +192,6 @@
193193 array( 'modifyField', 'user', 'ug_group', 'patch-ug_group-length-increase.sql' ),
194194 array( 'addField', 'uploadstash', 'us_chunk_inx', 'patch-uploadstash_chunk.sql' ),
195195 array( 'addfield', 'job', 'job_timestamp', 'patch-jobs-add-timestamp.sql' ),
196 - array( 'dropAncientTables' ),
197 - array( 'cleanupTextTable' ),
198196 );
199197 }
200198
@@ -855,52 +853,4 @@
856854 $this->applyPatch( 'patch-user-newtalk-timestamp-null.sql' );
857855 $this->output( "done.\n" );
858856 }
859 -
860 - protected function dropAncientTables() {
861 - $ancientTables = array(
862 - 'blobs', // 1.4
863 - 'brokenlinks', // 1.4
864 - 'cur', // 1.4
865 - 'ip_blocks_old', // Temporary in 1.6
866 - 'links', // 1.4
867 - 'linkscc', // 1.4
868 - 'old', // 1.4
869 - 'oldwatchlist', // pre 1.1?
870 - 'trackback', // 1.19
871 - 'user_rights', // 1.5
872 - 'validate', // 1.6
873 - );
874 -
875 - foreach( $ancientTables as $table ) {
876 - if ( $this->db->tableExists( $table, __METHOD__ ) ) {
877 - $this->db->dropTable( $table, __METHOD__ );
878 - }
879 - }
880 - }
881 -
882 - protected function cleanupTextTable() {
883 - $this->output( "Cleaning up text table\n" );
884 -
885 - /*$oldIndexes = array(
886 - 'old_namespace',
887 - 'old_timestamp',
888 - 'name_title_timestamp',
889 - 'user_timestamp',
890 - 'usertext_timestamp',
891 - );*/
892 - $this->dropIndex( 'text', 'old_namespace', 'patch-drop_old_text_indexes.sql' );
893 -
894 - /*$oldFields = array(
895 - 'old_namespace',
896 - 'old_title',
897 - 'old_comment',
898 - 'old_user',
899 - 'old_user_text',
900 - 'old_timestamp',
901 - 'old_minor_edit',
902 - 'inverse_timestamp',
903 - );*/
904 - $this->dropField( 'text', 'old_namespace', 'patch-drop_old_text_fields.sql' );
905 - }
906 -
907857 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108502Noticed looking at schema posted by Joerg in bug 33228...reedy14:07, 10 January 2012
r108504Cleanup "text" (nee old) table, dropping old indexes and fields...reedy15:04, 10 January 2012

Status & tagging log