r108389 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108388‎ | r108389 | r108390 >
Date:08:41, 9 January 2012
Author:hashar
Status:ok
Tags:
Comment:
revert r108367 : breaks tests

When doing a change that break tests, update the tests in the same
commit. That makes the change more obvious and let us merge in
another branch easily.
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -1178,6 +1178,7 @@
11791179 $link = '';
11801180 }
11811181 }
 1182+ $auto = "$link$auto";
11821183 if ( $pre ) {
11831184 # written summary $presep autocomment (summary /* section */)
11841185 $auto = wfMsgExt( 'autocomment-prefix', array( 'escapenoentities', 'content' ) ) . $auto;
@@ -1187,7 +1188,7 @@
11881189 $auto .= wfMsgExt( 'colon-separator', array( 'escapenoentities', 'content' ) );
11891190 }
11901191 $auto = '<span class="autocomment">' . $auto . '</span>';
1191 - $comment = $pre . $link . $wgLang->getDirMark() . '<span dir="auto">' . $auto . $post . '</span>';
 1192+ $comment = $pre . $auto . $post;
11921193 return $comment;
11931194 }
11941195

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108367Fix the regression pointed out by Robin in r105855.amire8021:07, 8 January 2012

Status & tagging log