r10837 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r10836‎ | r10837 | r10838 >
Date:23:56, 29 August 2005
Author:vibber
Status:old
Tags:
Comment:
Bump to 1.3.15:
* Security fix for <math>
* Security fix for tables
Modified paths:
  • /branches/REL1_3/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_3/phase3/includes/Article.php (modified) (history)
  • /branches/REL1_3/phase3/includes/DefaultSettings.php (modified) (history)
  • /branches/REL1_3/phase3/includes/Parser.php (modified) (history)

Diff [purge]

Index: branches/REL1_3/phase3/includes/Article.php
@@ -258,6 +258,7 @@
259259 $striparray=array();
260260 $parser=new Parser();
261261 $parser->mOutputType=OT_WIKI;
 262+ $parser->mOptions = new ParserOptions();
262263 $striptext=$parser->strip($text, $striparray, true);
263264
264265 # now that we can be sure that no pseudo-sections are in the source,
@@ -823,6 +824,7 @@
824825 $striparray=array();
825826 $parser=new Parser();
826827 $parser->mOutputType=OT_WIKI;
 828+ $parser->mOptions = new ParserOptions();
827829 $oldtext=$parser->strip($oldtext, $striparray, true);
828830
829831 # now that we can be sure that no pseudo-sections are in the source,
Index: branches/REL1_3/phase3/includes/DefaultSettings.php
@@ -9,7 +9,7 @@
1010 # like $wgScriptPath, you must also localize everything that
1111 # depends on it.
1212
13 -$wgVersion = '1.3.14';
 13+$wgVersion = '1.3.15';
1414
1515 $wgSitename = 'MediaWiki'; # Please customize!
1616 $wgMetaNamespace = FALSE; # will be same as you set $wgSitename
Index: branches/REL1_3/phase3/includes/Parser.php
@@ -221,16 +221,14 @@
222222 }
223223
224224 # math
225 - $text = Parser::extractTags('math', $text, $math_content, $uniq_prefix);
226 - foreach( $math_content as $marker => $content ){
227 - if( $render ) {
228 - if( $this->mOptions->getUseTeX() ) {
 225+ if( $this->mOptions->getUseTeX() ) {
 226+ $text = Parser::extractTags('math', $text, $math_content, $uniq_prefix);
 227+ foreach( $math_content as $marker => $content ){
 228+ if( $render ) {
229229 $math_content[$marker] = renderMath( $content );
230230 } else {
231 - $math_content[$marker] = "&lt;math&gt;$content&lt;math&gt;";
 231+ $math_content[$marker] = "<math>$content</math>";
232232 }
233 - } else {
234 - $math_content[$marker] = "<math>$content</math>";
235233 }
236234 }
237235
Index: branches/REL1_3/phase3/RELEASE-NOTES
@@ -3,7 +3,20 @@
44 Security reminder: MediaWiki does not require PHP's register_globals
55 setting since version 1.2.0. If you have it on, turn it *off* if you can.
66
 7+== MediaWiki 1.3.15, 2005-08-29 ==
78
 9+MediaWiki 1.3.15 is a security maintenance release. It corrects across-site
 10+scripting security bug:
 11+
 12+* <math> tags were handled incorrectly when TeX rendering support is off,
 13+ as in the default configuration.
 14+
 15+Wikis where the optional math support has been *enabled* are not vulnerable.
 16+
 17+The 1.3.x series is no longer maintained except for security fixes;
 18+new users and those seeking bug fixes should upgrade to 1.4.9 or 1.5.0.
 19+
 20+
821 == Version 1.3.14, 2005-08-23 ==
922
1023 MediaWiki 1.3.14 is a security maintenance release.

Status & tagging log