r108339 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108338‎ | r108339 | r108340 >
Date:00:22, 8 January 2012
Author:krinkle
Status:ok
Tags:
Comment:
Re-do svn copy from r106516 preserving history
Modified paths:
  • /trunk/phase3/resources/mediawiki.special/mediawiki.special.changeemail.js (replaced) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.special/mediawiki.special.changeemail.js
@@ -2,6 +2,7 @@
33 * JavaScript for Special:ChangeEmail
44 */
55 ( function( $, mw ) {
 6+
67 /**
78 * Given an email validity status (true, false, null) update the label CSS class
89 */
@@ -26,13 +27,14 @@
2728 // Lame tip to let user know if its email is valid. See bug 22449
2829 // Only bind once for 'blur' so that the user can fill it in without errors
2930 // After that look at every keypress for direct feedback if it was invalid onblur
30 -$( '#wpNewEmail' ).one( 'blur', function() {
 31+$( '#mw-input-wpemailaddress' ).one( 'blur', function() {
3132 if ( $( '#mw-emailaddress-validity' ).length === 0 ) {
32 - $(this).after( '<label for="wpNewEmail" id="mw-emailaddress-validity"></label>' );
 33+ $(this).after( '<label for="mw-input-wpemailaddress" id="mw-emailaddress-validity"></label>' );
3334 }
3435 updateMailValidityLabel( $(this).val() );
3536 $(this).keyup( function() {
3637 updateMailValidityLabel( $(this).val() );
3738 } );
3839 } );
39 -} )( jQuery, mediaWiki );
\ No newline at end of file
 40+
 41+} )( jQuery, mediaWiki );
Property changes on: trunk/phase3/resources/mediawiki.special/mediawiki.special.changeemail.js
___________________________________________________________________
Added: svn:mergeinfo
4042 Merged /branches/new-installer/phase3/resources/mediawiki.special/mediawiki.special.preferences.js:r43664-66004
4143 Merged /branches/REL1_15/phase3/resources/mediawiki.special/mediawiki.special.preferences.js:r51646
4244 Merged /branches/REL1_17/phase3/resources/mediawiki.special/mediawiki.special.preferences.js:r81445,81448
4345 Merged /branches/sqlite/resources/mediawiki.special/mediawiki.special.preferences.js:r58211-58321

Follow-up revisions

RevisionCommit summaryAuthorDate
r108340Re-applying change to code from r106516...krinkle00:24, 8 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106516Follow-up r92924: move the CSS/JS for e-mail validation to Special:ChangeEmail....robin18:31, 17 December 2011

Status & tagging log