r108322 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108321‎ | r108322 | r108323 >
Date:15:43, 7 January 2012
Author:bawolff
Status:ok
Tags:
Comment:
(follow-up r108145) Mark test as needing a database, and fix bug number in comment.
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/tests/phpunit/skins/SideBarTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/skins/SideBarTest.php
@@ -106,7 +106,10 @@
107107 );
108108
109109 }
110 - /** bug 33321 */
 110+ /**
 111+ * bug 33321 - Make sure there's a | after transforming.
 112+ * @group Database
 113+ */
111114 function testTrickyPipe() {
112115 $this->assertSidebar(
113116 array( 'Title' => array(
Index: trunk/phase3/includes/Skin.php
@@ -1246,7 +1246,7 @@
12471247 $line = array_map( 'trim', explode( '|', $line, 2 ) );
12481248 if ( count( $line ) !== 2 ) {
12491249 // Second sanity check, could be hit by people doing
1250 - // funky stuff with parserfuncs... (bug 3321)
 1250+ // funky stuff with parserfuncs... (bug 33321)
12511251 continue;
12521252 }
12531253

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108145(bug 33321. Sort of) Adding a line to MediaWiki:Sidebar that contains a pipe,...bawolff15:34, 5 January 2012

Status & tagging log