r108311 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108310‎ | r108311 | r108312 >
Date:09:27, 7 January 2012
Author:nikerabbit
Status:reverted
Tags:
Comment:
Throw an exception to aid debugging
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/View.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/View.php
@@ -170,6 +170,9 @@
171171 $changed_thread = $revision->getChangeObject();
172172 $curr_rev_id = $changed_thread->rootRevision();
173173 $curr_rev = Revision::newFromId( $curr_rev_id );
 174+ if ( !$curr_rev ) {
 175+ throw new MWException( "Undefined revision in diffQuery" );
 176+ }
174177 $prev_rev = $curr_rev->getPrevious();
175178 $oldid = $prev_rev ? $prev_rev->getId() : "";
176179

Follow-up revisions

RevisionCommit summaryAuthorDate
r108314Just shuptup the error instead, I have no interested in finding out why Lqt h...nikerabbit10:07, 7 January 2012

Status & tagging log