r108283 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108282‎ | r108283 | r108284 >
Date:21:25, 6 January 2012
Author:mah
Status:ok
Tags:
Comment:
minor w/s + move $title instantiation above Enotif
Modified paths:
  • /trunk/phase3/includes/RecentChange.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/RecentChange.php
@@ -158,7 +158,7 @@
159159
160160 /**
161161 * Writes the data in this object to the database
162 - * @param $noudp bool
 162+ * @param $noudp bool
163163 */
164164 public function save( $noudp = false ) {
165165 global $wgLocalInterwiki, $wgPutIPinRC;
@@ -214,10 +214,11 @@
215215 $editor = ($wgUser->getName() == $this->mAttribs['rc_user_text']) ?
216216 $wgUser : User::newFromName( $this->mAttribs['rc_user_text'], false );
217217 }
 218+ $title = Title::makeTitle( $this->mAttribs['rc_namespace'], $this->mAttribs['rc_title'] );
 219+
218220 # @todo FIXME: This would be better as an extension hook
219221 $enotif = new EmailNotification();
220 - $title = Title::makeTitle( $this->mAttribs['rc_namespace'], $this->mAttribs['rc_title'] );
221 - $enotif->notifyOnPageChange( $editor, $title,
 222+ $status = $enotif->notifyOnPageChange( $editor, $title,
222223 $this->mAttribs['rc_timestamp'],
223224 $this->mAttribs['rc_comment'],
224225 $this->mAttribs['rc_minor'],
@@ -731,7 +732,7 @@
732733 # see http://www.irssi.org/documentation/formats for some colour codes. prefix is \003,
733734 # no colour (\003) switches back to the term default
734735 $fullString = "$titleString\0034 $flag\00310 " .
735 - "\00302$url\003 \0035*\003 \00303$user\003 \0035*\003 $szdiff \00310$comment\003\n";
 736+ "\00302$url\003 \0035*\003 \00303$user\003 \0035*\003 $szdiff \00310$comment\003\n";
736737
737738 return $fullString;
738739 }

Status & tagging log