r108276 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108275‎ | r108276 | r108277 >
Date:20:06, 6 January 2012
Author:preilly
Status:ok
Tags:
Comment:
fix for undefined values
Modified paths:
  • /trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php
@@ -99,9 +99,10 @@
100100 $parsedHtml = $this->parseLinksForZeroQueryString( $html );
101101 $out->clearHTML();
102102 $out->addHTML( $parsedHtml );
 103+ $carrierLink = ( isset( self::$carrier['link'] ) ) ? self::$carrier['link'] : '';
103104 $bannerText = Html::rawElement( 'h3',
104105 array( 'id' => 'zero-rated-banner-text' ),
105 - wfMsg( 'zero-rated-mobile-access-banner-text', self::$carrier['link'] ) );
 106+ wfMsg( 'zero-rated-mobile-access-banner-text', $carrierLink ) );
106107 $banner = Html::rawElement( 'div',
107108 array( 'style' => 'display:none;',
108109 'id' => 'zero-rated-banner' ),
@@ -239,7 +240,7 @@
240241 if ( $zeroRatedLinkHref && substr( $zeroRatedLinkHref, 0, 1 ) !== '#' ) {
241242 $zeroPartnerUrl = $this->appendQueryString( $zeroRatedLinkHref,
242243 array( array( 'name' => 'zeropartner',
243 - 'value' => self::$carrier['partnerId'] ),
 244+ 'value' => ( isset( self::$carrier['partnerId'] ) ) ? self::$carrier['partnerId'] : 0 ),
244245 array('name' => 'renderZeroRatedBanner',
245246 'value' => 'true') ) );
246247 if ( $zeroPartnerUrl ) {
@@ -254,7 +255,7 @@
255256 if ( $zeroRatedExternalLinkHref && substr( $zeroRatedExternalLinkHref, 0, 1 ) !== '#' ) {
256257 $zeroPartnerUrl = $this->appendQueryString( $zeroRatedLinkHref,
257258 array( array( 'name' => 'zeropartner',
258 - 'value' => self::$carrier['partnerId'] ),
 259+ 'value' => ( isset( self::$carrier['partnerId'] ) ) ? self::$carrier['partnerId'] : 0 ),
259260 array('name' => 'renderZeroRatedBanner',
260261 'value' => 'true') ) );
261262 if ( $zeroPartnerUrl ) {
@@ -358,9 +359,13 @@
359360 $title = Title::newFromText( $carrierOptionsWikiPage, NS_MEDIAWIKI );
360361 // Use the revision directly to prevent other hooks to be called
361362 $rev = Revision::newFromTitle( $title );
362 - $sha1OfRev = $rev->getSha1();
363 - $key = wfMemcKey( 'zero-rated-mobile-access-carrier-options', $sha1OfRev );
364 - $carrierOptions = $wgMemc->get( $key );
 363+ if ( $rev ) {
 364+ $sha1OfRev = $rev->getSha1();
 365+ $key = wfMemcKey( 'zero-rated-mobile-access-carrier-options', $sha1OfRev );
 366+ $carrierOptions = $wgMemc->get( $key );
 367+ } else {
 368+ $carrierOptions = null;
 369+ }
365370
366371 if ( !$carrierOptions ) {
367372 $carrierOptions = array();
@@ -408,9 +413,13 @@
409414 $title = Title::newFromText( $languageOptionsWikiPage, NS_MEDIAWIKI );
410415 // Use the revision directly to prevent other hooks to be called
411416 $rev = Revision::newFromTitle( $title );
412 - $sha1OfRev = $rev->getSha1();
413 - $key = wfMemcKey( 'zero-rated-mobile-access-language-options', $sha1OfRev );
414 - $languageOptions = $wgMemc->get( $key );
 417+ if ( $rev ) {
 418+ $sha1OfRev = $rev->getSha1();
 419+ $key = wfMemcKey( 'zero-rated-mobile-access-language-options', $sha1OfRev );
 420+ $languageOptions = $wgMemc->get( $key );
 421+ } else {
 422+ $languageOptions = null;
 423+ }
415424
416425 if ( !$languageOptions ) {
417426 $languageOptions = array();

Status & tagging log