r108218 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108217‎ | r108218 | r108219 >
Date:11:41, 6 January 2012
Author:raymond
Status:ok
Tags:
Comment:
Read the language options from the content language. In case of content language != user language you would get an empty string.
Prefix the language options message with the extenaion name to avoid conflicts with core and/or other extension message keys
Refine message documentation
Modified paths:
  • /trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php (modified) (history)
  • /trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php
@@ -404,7 +404,7 @@
405405 private static function createLanguageOptionsFromWikiText() {
406406 global $wgMemc;
407407 wfProfileIn( __METHOD__ );
408 - $languageOptionsWikiPage = wfMsg( 'zero-rated-mobile-access-language-options-wiki-page' );
 408+ $languageOptionsWikiPage = wfMsgForContent( 'zero-rated-mobile-access-language-options-wiki-page' );
409409 $title = Title::newFromText( $languageOptionsWikiPage, NS_MEDIAWIKI );
410410 // Use the revision directly to prevent other hooks to be called
411411 $rev = Revision::newFromTitle( $title );
Index: trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.i18n.php
@@ -17,8 +17,7 @@
1818 $messages['en'] = array (
1919 'zero-rated-mobile-access-desc' => 'Provides features for mobile providers that provide free access',
2020 'zero-rated-mobile-access-search' => 'Search',
21 - 'zero-rated-mobile-access-language-options-wiki-page' => 'Language_options',
22 - 'zero-rated-mobile-access-carrier-options-wiki-page' => 'Carrier_options',
 21+ 'zero-rated-mobile-access-language-options-wiki-page' => 'zero-rated-mobile-access-language-options',
2322 'zero-rated-mobile-access-language-selection' => 'All languages',
2423 'zero-rated-mobile-access-home-page-selection' => '$1 home page',
2524 'zero-rated-mobile-access-home-page-selection-text' => 'Or go to the home page in the following language:',
@@ -34,13 +33,14 @@
3534 $messages['qqq'] = array(
3635 'zero-rated-mobile-access-desc' => '{{desc}}',
3736 'zero-rated-mobile-access-search' => 'Text for search action on the search button',
38 - 'zero-rated-mobile-access-language-options-wiki-page' => 'The name of the wiki page to store the country language data',
39 - 'zero-rated-mobile-access-carrier-options-wiki-page' => 'The name of the wiki page to store the carrier data',
 37+ 'zero-rated-mobile-access-language-options-wiki-page' => 'The name of the wiki page in the MediaWiki namespace to store the country language data',
4038 'zero-rated-mobile-access-language-selection' => 'Text to show the user when they select a language option',
41 - 'zero-rated-mobile-access-home-page-selection' => 'name of language followed by text to show user in local link to Wikipedia',
 39+ 'zero-rated-mobile-access-home-page-selection' => 'Name of language followed by text to show user in local link to Wikipedia',
4240 'zero-rated-mobile-access-home-page-selection-text' => 'Text to show user prior to selection of language option',
4341 'zero-rated-mobile-access-banner-text' => 'Text shown to users of various carriers with carrier name',
44 - 'zero-rated-mobile-access-banner-text-data-charges' => 'Data charges notice to user before images are displayed',
 42+ 'zero-rated-mobile-access-banner-text-data-charges' => 'Data charges notice to user before images are displayed
 43+* $1 = {{Msg-mw|zero-rated-mobile-access-banner-text-data-charges-yes}}
 44+* $2 = {{Msg-mw|zero-rated-mobile-access-banner-text-data-charges-no}}',
4545 'zero-rated-mobile-access-banner-text-data-charges-yes' => 'Text for accepting charges',
4646 'zero-rated-mobile-access-banner-text-data-charges-no' => 'Text for rejecting charges',
4747 );
@@ -51,5 +51,5 @@
5252 $messages['ja'] = array (
5353 'zero-rated-mobile-access-desc' => 'ゼロ格モバイルアクセス',
5454 'zero-rated-mobile-access-search' => '検索する',
55 - 'zero-rated-mobile-access-language-options-wiki-page' => 'Language_options',
5655 );
 56+

Status & tagging log