r108176 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108175‎ | r108176 | r108177 >
Date:20:31, 5 January 2012
Author:reedy
Status:ok
Tags:
Comment:
Documentation

Remove unreachable return

Remove unused globals
Modified paths:
  • /trunk/extensions/AbuseFilter/Views/AbuseFilterViewRevert.php (modified) (history)
  • /trunk/extensions/Translate/tag/PageTranslationHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/tag/PageTranslationHooks.php
@@ -16,7 +16,13 @@
1717 // Uuugly hack
1818 static $allowTargetEdit = false;
1919
20 - /// Hook: ParserBeforeStrip
 20+ /**
 21+ * Hook: ParserBeforeStrip
 22+ * @param $parser Parser
 23+ * @param $text
 24+ * @param $state
 25+ * @return bool
 26+ */
2127 public static function renderTagPage( $parser, &$text, $state ) {
2228 $title = $parser->getTitle();
2329
Index: trunk/extensions/AbuseFilter/Views/AbuseFilterViewRevert.php
@@ -7,14 +7,12 @@
88 function show() {
99 $filter = $this->mPage->mFilter;
1010
11 - global $wgUser, $wgOut;
1211 $user = $this->getUser();
1312 $out = $this->getOutput();
1413 $sk = $this->getSkin();
1514
1615 if ( !$user->isAllowed( 'abusefilter-revert' ) ) {
1716 throw new PermissionsError( 'abusefilter-revert' );
18 - return;
1917 }
2018
2119 $this->loadParameters();

Status & tagging log