r108151 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108150‎ | r108151 | r108152 >
Date:17:10, 5 January 2012
Author:greg
Status:ok
Tags:
Comment:
For new 'export all' feature, cleanup whitepspace, remove redundant check, add documentation. Bug 10574y
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/specials/SpecialExport.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesQqq.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -117,6 +117,7 @@
118118 * Extensions can use the RequestContextCreateSkin hook to override what skin is
119119 loaded in some contexts.
120120 * (bug 33456) Show $wgQueryCacheLimit on cached query pages.
 121+* (bug 10574) Add an option to allow all pages to be exported by Special:Export.
121122
122123 === Bug fixes in 1.19 ===
123124 * $wgUploadNavigationUrl should be used for file redlinks if.
Index: trunk/phase3/includes/specials/SpecialExport.php
@@ -264,7 +264,7 @@
265265 private function doExport( $page, $history, $list_authors, $exportall ) {
266266
267267 // If we are grabbing everything, enable full history and ignore the rest
268 - if ($exportall) {
 268+ if ( $exportall ) {
269269 $history = WikiExporter::FULL;
270270 } else {
271271
@@ -310,7 +310,7 @@
311311 }
312312
313313 /* Ok, let's get to it... */
314 - if( $history == WikiExporter::CURRENT && ! $exportall ) {
 314+ if( $history == WikiExporter::CURRENT ) {
315315 $lb = false;
316316 $db = wfGetDB( DB_SLAVE );
317317 $buffer = WikiExporter::BUFFER;
Index: trunk/phase3/languages/messages/MessagesQqq.php
@@ -2983,6 +2983,7 @@
29842984 # Export
29852985 'export' => 'Page title of [[Special:Export]], a page where a user can export pages from a wiki to a file.',
29862986 'exporttext' => 'Main text on [[Special:Export]]. Leave the line <tt><nowiki>[[{{#Special:Export}}/{{MediaWiki:Mainpage}}]]</nowiki></tt> exactly as it is!',
 2987+'exportall' => 'A label of checkbox option in [[Special:Export]]',
29872988 'exportcuronly' => 'A label of checkbox option in [[Special:Export]]',
29882989 'export-submit' => 'Button name in [[Special:Export]].
29892990

Status & tagging log