r108112 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108111‎ | r108112 | r108113 >
Date:02:24, 5 January 2012
Author:mah
Status:ok
Tags:
Comment:
Fix Bug 33496 - Misleading comment regarding preformatted font in commonElements.css
Author: Erwin Dokter
Modified paths:
  • /trunk/phase3/skins/common/commonElements.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/commonElements.css
@@ -185,10 +185,10 @@
186186 }*/
187187 pre, code, tt, kbd, samp {
188188 /*
189 - * It's important for this rule to first reference an actual font name, some browsers will render the monospace text
190 - * too small otherwise, namely Firefox, Chrome and Safari
 189+ * Some browsers will render the monospace text too small, namely Firefox, Chrome and Safari.
 190+ * Specifying any valid, second value will trigger correct behaviour without forcing a different font.
191191 */
192 - font-family: monospace, "Courier New";
 192+ font-family: monospace, Courier;
193193 }
194194 code {
195195 background-color: #f9f9f9;

Follow-up revisions

RevisionCommit summaryAuthorDate
r108123test rendering font-family for monospaced fonts...hashar09:16, 5 January 2012
r108142explanations by Erwin Dokter on bug 33496hashar15:06, 5 January 2012

Status & tagging log