r108077 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108076‎ | r108077 | r108078 >
Date:19:58, 4 January 2012
Author:bsitu
Status:ok
Tags:
Comment:
followup to -r108073 - Adding Proto_canonical to wfexpandurl() and drop the use of empty() to avoid hidden bugs
Modified paths:
  • /trunk/extensions/MoodBar/FeedbackResponseItem.php (modified) (history)
  • /trunk/extensions/MoodBar/include/MoodBarHTMLEmailNotification.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/include/MoodBarHTMLEmailNotification.php
@@ -265,7 +265,7 @@
266266 foreach ( $pageObject as $key => $value ) {
267267 $links[$key.'Url'] = wfExpandUrl( wfAppendQuery( $clickTrackingLink,
268268 array( 'redirectto' => $value->getLinkURL(),
269 - 'namespacenumber' => $value->getNamespace() ) ) );
 269+ 'namespacenumber' => $value->getNamespace() ) ), PROTO_CANONICAL );
270270 }
271271 }
272272
Index: trunk/extensions/MoodBar/FeedbackResponseItem.php
@@ -285,7 +285,7 @@
286286 */
287287 public static function update( $mbfr_id, $values ) {
288288
289 - if ( empty( $values ) ) {
 289+ if ( !$values ) {
290290 return;
291291 }
292292

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108073Adding mbfr_enotif_sent to track if a response notification email is sentbsitu19:40, 4 January 2012

Status & tagging log