r108067 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108066‎ | r108067 | r108068 >
Date:19:10, 4 January 2012
Author:yaron
Status:deferred
Tags:
Comment:
Follow-up to r102365 and r104814 - checks for both blank and null are needed
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_TemplateInForm.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_TemplateInForm.php
@@ -189,7 +189,7 @@
190190 if ( $this->mAllowMultiple ) {
191191 $text .= "|multiple";
192192 }
193 - if ( !is_null( $this->mLabel ) ) {
 193+ if ( $this->mLabel != '' ) {
194194 $text .= "|label=" . $this->mLabel;
195195 }
196196 $text .= "}}}\n";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102365strict comparators for empty stringsjeroendedauw02:25, 8 November 2011
r104814Fix for r102365 - replaced check for blank with check for nullyaron00:46, 1 December 2011