r108067 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r108066
|
r108067
|
r108068
>
Date:
19:10, 4 January 2012
Author:
yaron
Status:
deferred
Tags:
Comment:
Follow-up to
r102365
and
r104814
- checks for both blank and null are needed
Modified paths:
/trunk/extensions/SemanticForms/includes/SF_TemplateInForm.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/extensions/SemanticForms/includes/SF_TemplateInForm.php
—
—
@@ -189,7 +189,7 @@
190
190
if ( $this->mAllowMultiple ) {
191
191
$text .= "|multiple";
192
192
}
193
- if ( !is_null( $this->mLabel ) ) {
193
+ if ( $this->mLabel != '' ) {
194
194
$text .= "|label=" . $this->mLabel;
195
195
}
196
196
$text .= "}}}\n";
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r102365
strict comparators for empty strings
jeroendedauw
02:25, 8 November 2011
r104814
Fix for
r102365
- replaced check for blank with check for null
yaron
00:46, 1 December 2011