r108053 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108052‎ | r108053 | r108054 >
Date:17:15, 4 January 2012
Author:catrope
Status:ok
Tags:
Comment:
Revert r107066, see CR comments for full rationale. Basically this moves the previewed CSS to the wrong place in the <head> while not actually applying Janus
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -3196,7 +3196,7 @@
31973197 array( 'excludepage' => $this->getTitle()->getPrefixedDBkey() )
31983198 );
31993199 // Load the previewed CSS
3200 - $this->addInlineStyle( $this->getRequest()->getText( 'wpTextbox1' ) );
 3200+ $otherTags .= Html::inlineStyle( $this->getRequest()->getText( 'wpTextbox1' ) );
32013201 } else {
32023202 // Load the user styles normally
32033203 $moduleStyles[] = 'user';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107066apply CSS::Janus when user preview its CSS style...hashar13:35, 22 December 2011

Status & tagging log