r108047 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108046‎ | r108047 | r108048 >
Date:16:20, 4 January 2012
Author:amire80
Status:ok
Tags:
Comment:
Added Html::openElement/closeElement and moved <tbody> before <tfoot> (thank you, Firefox source viewer).
Modified paths:
  • /trunk/extensions/Translate/specials/SpecialLanguageStats.php (modified) (history)
  • /trunk/extensions/Translate/specials/SpecialMessageGroupStats.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/specials/SpecialMessageGroupStats.php
@@ -131,9 +131,11 @@
132132 $table->setMainColumnHeader( wfMessage( 'translate-mgs-column-language' ) );
133133 $out = $table->createHeader() . "\n" . $out;
134134 $out .= Html::closeElement( 'tbody' );
135 - $out .= '<tfoot>';
 135+
 136+ $out .= Html::openElement( 'tfoot' );
136137 $out .= $table->makeTotalRow( wfMessage( 'translate-mgs-totals' ), $this->totals );
137 - $out .= '</tfoot>';
 138+ $out .= Html::closeElement( 'tfoot' );
 139+
138140 $out .= Html::closeElement( 'table' );
139141 return $out;
140142 } else {
Index: trunk/extensions/Translate/specials/SpecialLanguageStats.php
@@ -289,10 +289,12 @@
290290 if ( $out ) {
291291 $table->setMainColumnHeader( wfMessage( 'translate-ls-column-group' ) );
292292 $out = $table->createHeader() . "\n" . $out;
293 - $out .= '<tfoot>';
 293+ $out .= Html::closeElement( 'tbody' );
 294+
 295+ $out .= Html::openElement( 'tfoot' );
294296 $out .= $table->makeTotalRow( wfMessage( 'translate-languagestats-overall' ), $this->totals );
295 - $out .= '</tfoot>';
296 - $out .= Html::closeElement( 'tbody' );
 297+ $out .= Html::closeElement( 'tfoot' );
 298+
297299 $out .= Html::closeElement( 'table' );
298300 return $out;
299301 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108020Add the totals row to <tfoot> to exclude it from sorting. Requested by Siebra...nikerabbit13:03, 4 January 2012

Status & tagging log