r108014 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108013‎ | r108014 | r108015 >
Date:11:06, 4 January 2012
Author:gwicke
Status:ok
Tags:
Comment:
Fix JSHint warnings (mostly about comment indentation) from r108012.
Modified paths:
  • /trunk/extensions/VisualEditor/modules/parser/mediawiki.parser.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/parser/mediawiki.parser.js
@@ -30,10 +30,10 @@
3131 this.wikiTokenizer = new PegTokenizer();
3232
3333 /**
34 - * Token stream transformations.
35 - * This is where all the wiki functionality is implemented.
36 - * See https://www.mediawiki.org/wiki/Future/Parser_development/Token_stream_transformations
37 - */
 34+ * Token stream transformations.
 35+ * This is where all the wiki-specific functionality is implemented.
 36+ * See https://www.mediawiki.org/wiki/Future/Parser_development/Token_stream_transformations
 37+ */
3838 this.tokenTransformer = new TokenTransformDispatcher ();
3939
4040 // Add token transformations..
@@ -46,15 +46,15 @@
4747 this.tokenTransformer.listenForTokensFrom( this.wikiTokenizer );
4848
4949 /**
50 - * The tree builder creates a DOM tree from the token soup emitted from
51 - * the TokenTransformDispatcher.
52 - */
 50+ * The tree builder creates a DOM tree from the token soup emitted from
 51+ * the TokenTransformDispatcher.
 52+ */
5353 this.treeBuilder = new FauxHTML5.TreeBuilder();
5454 this.treeBuilder.listenForTokensFrom( this.tokenTransformer );
5555
5656 /**
57 - * Final processing on the HTML DOM.
58 - */
 57+ * Final processing on the HTML DOM.
 58+ */
5959
6060 // Generic DOM transformer.
6161 // This currently performs minor tree-dependent clean up like wrapping
@@ -65,13 +65,13 @@
6666
6767
6868 /**
69 - * Conversion from HTML DOM to WikiDOM. This is not needed if plain HTML
70 - * DOM output is needed, so it should only be registered to the
71 - * DOMPostProcessor 'document' event if WikiDom output is requested. We
72 - * could emit events for 'dom', 'wikidom', 'html' and so on, but only
73 - * actually set up the needed pipeline stages if a listener is registered.
74 - * Overriding the addListener method should make this possible.
75 - */
 69+ * Conversion from HTML DOM to WikiDOM. This is not needed if plain HTML
 70+ * DOM output is needed, so it should only be registered to the
 71+ * DOMPostProcessor 'document' event if WikiDom output is requested. We
 72+ * could emit events for 'dom', 'wikidom', 'html' and so on, but only
 73+ * actually set up the needed pipeline stages if a listener is registered.
 74+ * Overriding the addListener method should make this possible.
 75+ */
7676 this.DOMConverter = new DOMConverter();
7777
7878
@@ -89,7 +89,7 @@
9090 // and convert parser tests etc to listen on it! See comments above for ideas.
9191 ParserPipeline.prototype.setDocumentProperty = function ( document ) {
9292 this.document = document;
93 -}
 93+};
9494
9595
9696 // XXX: remove JSON serialization here, that should only be performed when

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108012Hook up the DOMPostProcessor using events as well, and rename the subscription...gwicke11:00, 4 January 2012

Status & tagging log