r108005 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108004‎ | r108005 | r108006 >
Date:10:08, 4 January 2012
Author:maxsem
Status:ok
Tags:
Comment:
Made WebInstaller::showStatusMessage() look uniformly for one and multiple errors/warnings per status
Modified paths:
  • /trunk/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstaller.php
@@ -677,12 +677,10 @@
678678 * @param $status Status
679679 */
680680 public function showStatusMessage( Status $status ) {
681 - $text = $status->getWikiText();
682 - $this->output->addWikiText(
683 - "<div class=\"config-message\">\n" .
684 - $text .
685 - "</div>"
686 - );
 681+ $errors = array_merge( $status->getErrorsArray(), $status->getWarningsArray() );
 682+ foreach ( $errors as $error ) {
 683+ call_user_func_array( array( $this, 'showMessage' ), $error );
 684+ }
687685 }
688686
689687 /**

Status & tagging log