r107964 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r107963‎ | r107964 | r107965 >
Date:23:42, 3 January 2012
Author:mah
Status:ok
Tags:
Comment:
re Bug 31007 - rebuildrecentchanges.php fails for Postgresql with strings for integers
Authors: "Max" and Tim Landscheidt

Unquote 'null'
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/maintenance/rebuildrecentchanges.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/rebuildrecentchanges.php
——@@ -119,11 +119,11 @@
120120 if ( $row ) {
121121 $lastOldId = intval( $row->rev_id );
122122 # Grab the last text size if available
123 - $lastSize = !is_null( $row->rev_len ) ? intval( $row->rev_len ) : 'NULL';
 123+ $lastSize = !is_null( $row->rev_len ) ? intval( $row->rev_len ) : null;
124124 } else {
125125 # No previous edit
126126 $lastOldId = 0;
127 - $lastSize = 'NULL';
 127+ $lastSize = null;
128128 $new = 1; // probably true
129129 }
130130 }
Index: trunk/phase3/CREDITS
——@@ -131,6 +131,7 @@
132132 * Mathias Ertl
133133 * Matthew Britton
134134 * mati
 135+* Max
135136 * Max Sikström
136137 * merl
137138 * Michael Dale
——@@ -170,6 +171,7 @@
171172 * Str4nd
172173 * svip
173174 * The Evil IP address
 175+* Tim Landscheidt
174176 * Tisane
175177 * Umherirrender
176178 * Van de Bugger

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97544* (bug 31007) Fix regression in rebuildrecentchanges maintenance script...brion20:00, 19 September 2011
r97545MFT r97544: fix bug 31007 regression in r77778brion20:02, 19 September 2011
r97546MFT r97544: fix bug 31007 regression in r77778brion20:02, 19 September 2011

Status & tagging log