r107957 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107956‎ | r107957 | r107958 >
Date:22:57, 3 January 2012
Author:reedy
Status:ok
Tags:
Comment:
Merge r107913 (merges r105007 from trunk) and r107924 (merges r106992 from trunk)
Modified paths:
  • /branches/wmf/1.18wmf1 (modified) (history)
  • /branches/wmf/1.18wmf1/resources/jquery/jquery.collapsibleTabs.js (modified) (history)
  • /branches/wmf/1.18wmf1/resources/jquery/jquery.delayedBind.js (modified) (history)
  • /branches/wmf/1.18wmf1/resources/mediawiki/mediawiki.util.js (modified) (history)
  • /branches/wmf/1.18wmf1/tests/qunit/index.html (modified) (history)
  • /branches/wmf/1.18wmf1/tests/qunit/suites/resources/jquery/jquery.delayedBind.test.js (added) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/tests/qunit/index.html
@@ -43,6 +43,7 @@
4444 <script src="../../resources/jquery/jquery.byteLength.js"></script>
4545 <script src="../../resources/jquery/jquery.byteLimit.js"></script>
4646 <script src="../../resources/jquery/jquery.colorUtil.js"></script>
 47+ <script src="../../resources/jquery/jquery.delayedBind.js"></script>
4748 <script src="../../resources/jquery/jquery.getAttrs.js"></script>
4849 <script src="../../resources/jquery/jquery.localize.js"></script>
4950 <script src="../../resources/jquery/jquery.tabIndex.js"></script>
@@ -69,6 +70,7 @@
7071 <script src="suites/resources/jquery/jquery.byteLength.js"></script>
7172 <script src="suites/resources/jquery/jquery.byteLimit.js"></script>
7273 <script src="suites/resources/jquery/jquery.colorUtil.js"></script>
 74+ <script src="suites/resources/jquery/jquery.delayedBind.test.js"></script>
7375 <script src="suites/resources/jquery/jquery.getAttrs.js"></script>
7476 <script src="suites/resources/jquery/jquery.localize.js"></script>
7577 <script src="suites/resources/jquery/jquery.tabIndex.js"></script>
Property changes on: branches/wmf/1.18wmf1/tests/qunit/index.html
___________________________________________________________________
Modified: svn:mergeinfo
7678 Merged /branches/REL1_18/phase3/tests/qunit/index.html:r107913,107924
Index: branches/wmf/1.18wmf1/tests/qunit/suites/resources/jquery/jquery.delayedBind.test.js
@@ -0,0 +1,41 @@
 2+test('jquery.delayedBind with data option', function() {
 3+ var $fixture = $('<div>').appendTo('body'),
 4+ data = { magic: "beeswax" },
 5+ delay = 50;
 6+
 7+ $fixture.delayedBind(delay, 'testevent', data, function(event) {
 8+ start(); // continue!
 9+ ok(true, 'testevent fired');
 10+ ok(event.data === data, 'data is passed through delayedBind');
 11+ });
 12+
 13+ expect(2);
 14+ stop(); // async!
 15+
 16+ // We'll trigger it thrice, but it should only happen once.
 17+ $fixture.trigger('testevent', {});
 18+ $fixture.trigger('testevent', {});
 19+ $fixture.trigger('testevent', {});
 20+ $fixture.trigger('testevent', {});
 21+});
 22+
 23+test('jquery.delayedBind without data option', function() {
 24+ var $fixture = $('<div>').appendTo('body'),
 25+ data = { magic: "beeswax" },
 26+ delay = 50;
 27+
 28+ $fixture.delayedBind(delay, 'testevent', function(event) {
 29+ start(); // continue!
 30+ ok(true, 'testevent fired');
 31+ });
 32+
 33+ expect(1);
 34+ stop(); // async!
 35+
 36+ // We'll trigger it thrice, but it should only happen once.
 37+ $fixture.trigger('testevent', {});
 38+ $fixture.trigger('testevent', {});
 39+ $fixture.trigger('testevent', {});
 40+ $fixture.trigger('testevent', {});
 41+});
 42+
Property changes on: branches/wmf/1.18wmf1/tests/qunit/suites/resources/jquery/jquery.delayedBind.test.js
___________________________________________________________________
Added: svn:eol-style
143 + native
Index: branches/wmf/1.18wmf1/resources/jquery/jquery.collapsibleTabs.js
@@ -24,7 +24,7 @@
2525 // if we haven't already bound our resize hanlder, bind it now
2626 if( !$.collapsibleTabs.boundEvent ) {
2727 $( window )
28 - .delayedBind( '500', 'resize', null, function( ) { $.collapsibleTabs.handleResize(); } );
 28+ .delayedBind( '500', 'resize', function( ) { $.collapsibleTabs.handleResize(); } );
2929 }
3030 // call our resize handler to setup the page
3131 $.collapsibleTabs.handleResize();
Index: branches/wmf/1.18wmf1/resources/jquery/jquery.delayedBind.js
@@ -19,6 +19,11 @@
2020 * @param callback Function to call
2121 */
2222 delayedBind: function( timeout, event, data, callback ) {
 23+ if ( arguments.length == 3 ) {
 24+ // Shift optional parameter down
 25+ callback = data;
 26+ data = undefined;
 27+ }
2328 var encEvent = encodeEvent( event );
2429 return this.each( function() {
2530 var that = this;
Index: branches/wmf/1.18wmf1/resources/mediawiki/mediawiki.util.js
@@ -164,12 +164,13 @@
165165 var s = document.createElement( 'style' );
166166 s.type = 'text/css';
167167 s.rel = 'stylesheet';
 168+ // Insert into document before setting cssText (bug 33305)
 169+ document.getElementsByTagName('head')[0].appendChild( s );
168170 if ( s.styleSheet ) {
169171 s.styleSheet.cssText = text; // IE
170172 } else {
171173 s.appendChild( document.createTextNode( text + '' ) ); // Safari sometimes borks on null
172174 }
173 - document.getElementsByTagName('head')[0].appendChild( s );
174175 return s.sheet || s;
175176 },
176177
Property changes on: branches/wmf/1.18wmf1/resources/mediawiki/mediawiki.util.js
___________________________________________________________________
Modified: svn:mergeinfo
177178 Merged /branches/REL1_18/phase3/resources/mediawiki/mediawiki.util.js:r107924
178179 Merged /trunk/phase3/resources/mediawiki/mediawiki.util.js:r106992
Property changes on: branches/wmf/1.18wmf1
___________________________________________________________________
Modified: svn:mergeinfo
179180 Merged /branches/REL1_18/phase3:r107913,107924
180181 Merged /trunk/phase3:r105007,106992

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105007Followup r104671: fix regression in jquery.delayedBind() due to change in par...brion21:47, 2 December 2011
r106992[Core JS] mw.util.addCSS: Insert style tag into dom before setting cssText...krinkle22:08, 21 December 2011
r107913MFT r105007reedy18:03, 3 January 2012
r107924Merge r106992, manually merge r107119reedy19:21, 3 January 2012

Status & tagging log