r107931 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107930‎ | r107931 | r107932 >
Date:19:44, 3 January 2012
Author:brion
Status:ok
Tags:
Comment:
Followup r107882: explicitly say text() or parse() on wfMessage() calls!
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUserrights.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserrights.php
@@ -441,9 +441,9 @@
442442 Html::hidden( 'user', $this->mTarget ) .
443443 Html::hidden( 'wpEditToken', $this->getUser()->getEditToken( $this->mTarget ) ) .
444444 Xml::openElement( 'fieldset' ) .
445 - Xml::element( 'legend', array(), wfMessage( 'userrights-editusergroup', $user->getName() ) ) .
 445+ Xml::element( 'legend', array(), wfMessage( 'userrights-editusergroup', $user->getName() )->text() ) .
446446 wfMessage( 'editinguser' )->params( wfEscapeWikiText( $user->getName() ) )->rawParams( $userToolLinks )->parse() .
447 - wfMessage( 'userrights-groups-help', $user->getName() ) .
 447+ wfMessage( 'userrights-groups-help', $user->getName() )->parse() .
448448 $grouplist .
449449 Xml::tags( 'p', null, $this->groupCheckboxes( $groups, $user ) ) .
450450 Xml::openElement( 'table', array( 'border' => '0', 'id' => 'mw-userrights-table-outer' ) ) .

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107882Fix gender on Special:Userrights...hashar12:48, 3 January 2012

Status & tagging log