r107910 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107909‎ | r107910 | r107911 >
Date:17:53, 3 January 2012
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/REL1_18/phase3 (modified) (history)
  • /branches/REL1_18/phase3/includes (modified) (history)
  • /branches/REL1_18/phase3/includes/db/DatabaseMysql.php (modified) (history)
  • /branches/REL1_18/phase3/includes/installer/CliInstaller.php (modified) (history)
  • /branches/REL1_18/phase3/includes/installer/Installer.php (modified) (history)
  • /branches/REL1_18/phase3/resources/jquery/jquery.collapsibleTabs.js (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/includes/db/DatabaseMysql.php
@@ -709,7 +709,7 @@
710710 protected function getDefaultSchemaVars() {
711711 $vars = parent::getDefaultSchemaVars();
712712 $vars['wgDBTableOptions'] = str_replace( 'TYPE', 'ENGINE', $GLOBALS['wgDBTableOptions'] );
713 - $vars['wgDBTableOptions'] = str_replace( 'CHARSET=mysql4', 'CHARSET=binary', $GLOBALS['wgDBTableOptions'] );
 713+ $vars['wgDBTableOptions'] = str_replace( 'CHARSET=mysql4', 'CHARSET=binary', $vars['wgDBTableOptions'] );
714714 return $vars;
715715 }
716716
Index: branches/REL1_18/phase3/includes/installer/Installer.php
@@ -842,8 +842,13 @@
843843 /**
844844 * Environment check for the server hostname.
845845 */
846 - protected function envCheckServer() {
847 - $server = WebRequest::detectServer();
 846+ protected function envCheckServer( $srv = null ) {
 847+ if ( $srv ) {
 848+ // wgServer was pre-defined, perhaps by the cli installer
 849+ $server = $srv;
 850+ } else {
 851+ $server = WebRequest::detectServer();
 852+ }
848853 $this->showMessage( 'config-using-server', $server );
849854 $this->setVar( 'wgServer', $server );
850855 }
Index: branches/REL1_18/phase3/includes/installer/CliInstaller.php
@@ -31,6 +31,7 @@
3232 'dbpass' => 'wgDBpassword',
3333 'dbschema' => 'wgDBmwschema',
3434 'dbpath' => 'wgSQLiteDataDir',
 35+ 'server' => 'wgServer',
3536 'scriptpath' => 'wgScriptPath',
3637 );
3738
@@ -183,6 +184,13 @@
184185 return parent::envCheckPath();
185186 }
186187
 188+ protected function envCheckServer( $srv = null ) {
 189+ if ( $this->getVar( 'wgServer' ) ) {
 190+ $srv = $this->getVar( 'wgServer' );
 191+ }
 192+ return parent::envCheckServer( $srv );
 193+ }
 194+
187195 public function dirIsExecutable( $dir, $url ) {
188196 $this->showMessage( 'config-no-cli-uploads-check', $dir );
189197 return false;
Property changes on: branches/REL1_18/phase3/includes/installer/CliInstaller.php
___________________________________________________________________
Modified: svn:mergeinfo
190198 Merged /trunk/phase3/includes/installer/CliInstaller.php:r102137,104576,104671,105010
Property changes on: branches/REL1_18/phase3/includes
___________________________________________________________________
Modified: svn:mergeinfo
191199 Merged /trunk/phase3/includes:r102137,104576,104671,105010
Index: branches/REL1_18/phase3/resources/jquery/jquery.collapsibleTabs.js
@@ -24,7 +24,7 @@
2525 // if we haven't already bound our resize hanlder, bind it now
2626 if( !$.collapsibleTabs.boundEvent ) {
2727 $( window )
28 - .delayedBind( '500', 'resize', function( ) { $.collapsibleTabs.handleResize(); } );
 28+ .delayedBind( '500', 'resize', null, function( ) { $.collapsibleTabs.handleResize(); } );
2929 }
3030 // call our resize handler to setup the page
3131 $.collapsibleTabs.handleResize();
Property changes on: branches/REL1_18/phase3
___________________________________________________________________
Modified: svn:mergeinfo
3232 Merged /trunk/phase3:r102137,104576,104671,105010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102137Make the CliInstaller use --server to set wgServer instead of always setting ...dantman01:15, 6 November 2011
r104576Fix r102137. CliInstaller needs to override wgServer, but not in a manner tha...demon17:59, 29 November 2011
r104671(bug 31212) History tab not collapsed when the screen is narrow. Patch by Mic...catrope13:16, 30 November 2011
r105010Per Timo, the second line would wipe out the firstreedy21:50, 2 December 2011

Status & tagging log