r107887 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107886‎ | r107887 | r107888 >
Date:15:14, 3 January 2012
Author:reedy
Status:ok
Tags:
Comment:
Fix non reverted job_insert_timestamp

Fixup timestamp addition per Roan

Ping r107886
Modified paths:
  • /trunk/phase3/includes/job/JobQueue.php (modified) (history)
  • /trunk/phase3/maintenance/tables.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/job/JobQueue.php
@@ -352,7 +352,7 @@
353353 'job_cmd' => $this->command,
354354 'job_namespace' => $this->title->getNamespace(),
355355 'job_title' => $this->title->getDBkey(),
356 - 'job_insert_timestamp' => wfTimestampNow(),
 356+ 'job_timestamp' => $dbw->timestamp(),
357357 'job_params' => Job::makeBlob( $this->params )
358358 );
359359 }
Index: trunk/phase3/maintenance/tables.sql
@@ -1273,7 +1273,7 @@
12741274 ) /*$wgDBTableOptions*/;
12751275
12761276 CREATE INDEX /*i*/job_cmd ON /*_*/job (job_cmd, job_namespace, job_title, job_params(128));
1277 -CREATE INDEX /*i*/job_insert_timestamp ON /*_*/job(job_insert_timestamp);
 1277+CREATE INDEX /*i*/job_timestamp ON /*_*/job(job_timestamp);
12781278
12791279
12801280 -- Details of updates to cached special pages

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107886* (bug 27724) Add timestamp to job queue....reedy15:08, 3 January 2012

Status & tagging log