r107878 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107877‎ | r107878 | r107879 >
Date:11:05, 3 January 2012
Author:johnduhart
Status:ok
Tags:reedy 
Comment:
Missing check for ISMULTI on help parameters, thanks santhosh
Modified paths:
  • /trunk/phase3/includes/api/ApiBase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiBase.php
@@ -385,7 +385,7 @@
386386
387387 $type = isset( $paramSettings[self::PARAM_TYPE] ) ? $paramSettings[self::PARAM_TYPE] : null;
388388 if ( isset( $type ) ) {
389 - if ( isset( $paramSettings[self::PARAM_ISMULTI] ) ) {
 389+ if ( isset( $paramSettings[self::PARAM_ISMULTI] ) && $paramSettings[self::PARAM_ISMULTI] ) {
390390 $prompt = 'Values (separate with \'|\'): ';
391391 } else {
392392 $prompt = 'One value: ';

Status & tagging log