r107856 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r107855‎ | r107856 | r107857 >
Date:23:19, 2 January 2012
Author:tstarling
Status:ok
Tags:
Comment:
MFT r107623: fix {{NAMESPACE}} etc. in tracking category name messages
Modified paths:
  • /branches/wmf/1.18wmf1/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/parser/Parser.php
——@@ -3724,7 +3724,11 @@
37253725 wfDebug( __METHOD__.": Not adding tracking category $msg to special page!\n" );
37263726 return false;
37273727 }
3728 - $cat = wfMsgForContent( $msg );
 3728+ // Important to parse with correct title (bug 31469)
 3729+ $cat = wfMessage( $msg )
 3730+ ->title( $this->getTitle() )
 3731+ ->inContentLanguage()
 3732+ ->text();
37293733
37303734 # Allow tracking categories to be disabled by setting them to "-"
37313735 if ( $cat === '-' ) {
Property changes on: branches/wmf/1.18wmf1/includes/parser/Parser.php
___________________________________________________________________
Added: svn:mergeinfo
37323736 Merged /branches/new-installer/phase3/includes/parser/Parser.php:r43664-66004
37333737 Merged /branches/wmf-deployment/includes/parser/Parser.php:r53381
37343738 Merged /branches/REL1_15/phase3/includes/parser/Parser.php:r51646
37353739 Merged /branches/REL1_18/phase3/includes/parser/Parser.php:r102560,103033,103041,103054
37363740 Merged /branches/sqlite/includes/parser/Parser.php:r58211-58321
37373741 Merged /trunk/phase3/includes/parser/Parser.php:r92580,92634,92713,92762,92765,92791,92854,92884,92886-92887,92894,92898,92907,92932,92958,93141,93149,93151,93233-93234,93258,93266,93303,93516-93518,93818-93822,93847,93858,93891,93935-93936,93977,94058,94062,94068,94107,94155,94235,94277,94346,94372,94422,94425,94444,94448,94456,94498,94517,94601,94630,94728,94738,94825,94862,94995-94997,95023,95042,95072-95073,95155,95327,95332,95410,95422,95426,95442,95468,95601,95812,96178,96182,97175,97810,98578,98598,98656,98764,98990,99304,99308,99349,99477,99694,100219,100221,100223,100226,100239,100242,100575,101291,101306,101314,101445,101464,101591,101666,101802,101860,101990,102297,102334-102335,102440,102951,102954,104318,104322,104350,104434,104441,104445,104470,104475,107623

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107623(bug 31469) Make sure tracking category messages expand variables like...bawolff06:44, 30 December 2011

Status & tagging log