r107838 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107837‎ | r107838 | r107839 >
Date:17:16, 2 January 2012
Author:ialex
Status:ok
Tags:
Comment:
Use $wgUser instead of the User from the context in Article::view() and Article::showDiffPage() for consistency
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -458,7 +458,7 @@
459459 wfDebug( __METHOD__ . ": done file cache\n" );
460460 # tell wgOut that output is taken care of
461461 $wgOut->disable();
462 - $this->mPage->doViewUpdates( $this->getContext()->getUser() );
 462+ $this->mPage->doViewUpdates( $wgUser );
463463 wfProfileOut( __METHOD__ );
464464
465465 return;
@@ -630,7 +630,7 @@
631631 $wgOut->setFollowPolicy( $policy['follow'] );
632632
633633 $this->showViewFooter();
634 - $this->mPage->doViewUpdates( $this->getContext()->getUser() );
 634+ $this->mPage->doViewUpdates( $wgUser );
635635
636636 wfProfileOut( __METHOD__ );
637637 }
@@ -669,7 +669,7 @@
670670
671671 if ( $diff == 0 || $diff == $this->mPage->getLatest() ) {
672672 # Run view updates for current revision only
673 - $this->mPage->doViewUpdates( $this->getContext()->getUser() );
 673+ $this->mPage->doViewUpdates( $wgUser );
674674 }
675675 }
676676

Status & tagging log