r107829 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107828‎ | r107829 | r107830 >
Date:13:09, 2 January 2012
Author:nikerabbit
Status:ok
Tags:
Comment:
Get rid of ugly flash effect, and remove one place where using this modules makes no sense
Modified paths:
  • /trunk/extensions/Translate/Translate.php (modified) (history)
  • /trunk/extensions/Translate/utils/MessageWebImporter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/Translate.php
@@ -162,6 +162,7 @@
163163 // Client-side resource modules
164164 $wgResourceModules['ext.translate'] = array(
165165 'styles' => 'resources/ext.translate.css',
 166+ 'position' => 'top',
166167 ) + $resourcePaths;
167168
168169 $wgResourceModules['ext.translate.messagetable'] = array(
Index: trunk/extensions/Translate/utils/MessageWebImporter.php
@@ -105,9 +105,6 @@
106106 * @return string
107107 */
108108 protected function doHeader() {
109 - global $wgOut;
110 - $wgOut->addModules( 'ext.translate' );
111 -
112109 $formParams = array(
113110 'method' => 'post',
114111 'action' => $this->getAction(),

Status & tagging log