r107787 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r107786‎ | r107787 | r107788 >
Date:23:23, 1 January 2012
Author:krinkle
Status:ok
Tags:
Comment:
[WebFonts] fix #pt-webfonts icon position
* Core uses padding-left 15px for a 13px-wide icon
* So this should use padding-left 18px as this icon is 16px wide. Before the icon was slightly overlaying the left edge of the label, now there's padding in between, like there for core #pt-userpage
* Also removed redundant background properties, same as core #pt-userpage stylings
Modified paths:
  • /trunk/extensions/WebFonts/resources/ext.webfonts.css (modified) (history)

Diff [purge]

Index: trunk/extensions/WebFonts/resources/ext.webfonts.css
——@@ -1,7 +1,7 @@
22 li#pt-webfont {
33 /* @embed */
4 - background: url(images/font-icon.png) no-repeat scroll left top transparent;
5 - padding-left: 15px !important;
 4+ background: url(images/font-icon.png) no-repeat 0 0;
 5+ padding-left: 18px !important;
66 }
77
88 div#webfonts-menu {
——@@ -10,7 +10,7 @@
1111 display: none;
1212 }
1313
14 -div#webfonts-menu.open{
 14+div#webfonts-menu.open {
1515 display: block;
1616 }
1717 div#webfonts-fonts {

Sign-offs

UserFlagDate
Nikerabbitinspected06:50, 2 January 2012
Nikerabbittested06:56, 2 January 2012

Status & tagging log