r107779 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107778‎ | r107779 | r107780 >
Date:18:36, 1 January 2012
Author:reedy
Status:ok
Tags:
Comment:
Fix undefined $dbw

Documentation!
Modified paths:
  • /trunk/extensions/Renameuser/renameUserCleanup.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Renameuser/renameUserCleanup.php
@@ -49,16 +49,19 @@
5050 $this->checkRenameLog( $olduser, $newuser );
5151
5252 if ( $olduid ) {
53 - $this->doUpdates( $olduser, $newuser, $olduid, $dbw );
 53+ $this->doUpdates( $olduser, $newuser, $olduid );
5454 }
55 - $this->doUpdates( $olduser, $newuser, $newuser->getId(), $dbw );
56 - $this->doUpdates( $olduser, $newuser, 0, $dbw );
 55+ $this->doUpdates( $olduser, $newuser, $newuser->getId() );
 56+ $this->doUpdates( $olduser, $newuser, 0 );
5757
5858 print "Done!\n";
5959 exit(0);
6060 }
6161
62 -
 62+ /**
 63+ * @param $olduser User
 64+ * @param $newuser User
 65+ */
6366 public function checkUserExistence( $olduser, $newuser ) {
6467 if ( !$newuser->getId() ) {
6568 $this->error( "No such user: " . $this->getOption( 'newuser' ), true );
@@ -78,6 +81,10 @@
7982 }
8083 }
8184
 85+ /**
 86+ * @param $olduser User
 87+ * @param $newuser User
 88+ */
8289 public function checkRenameLog( $olduser, $newuser ) {
8390 $dbr = wfGetDB( DB_SLAVE );
8491
@@ -111,14 +118,12 @@
112119 print "Exiting at user's request\n";
113120 exit(1);
114121 }
115 - }
116 - else {
 122+ } else {
117123 foreach ( $result as $row ) {
118124 print "Found possible log entry of the rename, please check: ".$row->log_title." with comment ".$row->log_comment." on $row->log_timestamp\n";
119125 }
120126 }
121 - }
122 - else {
 127+ } else {
123128 foreach ( $result as $row ) {
124129 print "Found log entry of the rename: ".$olduser->getName()." to ".$newuser->getName()." on $row->log_timestamp\n";
125130 }
@@ -135,8 +140,12 @@
136141 }
137142 }
138143
139 -
140 - public function doUpdates( $olduser, $newuser, $uid, $dbw ) {
 144+ /**
 145+ * @param $olduser User
 146+ * @param $newuser User
 147+ * @param $uid
 148+ */
 149+ public function doUpdates( $olduser, $newuser, $uid ) {
141150 $this->updateTable( 'revision', 'rev_user_text', 'rev_user', 'rev_timestamp', $olduser, $newuser, $uid );
142151 $this->updateTable( 'archive', 'ar_user_text', 'ar_user', 'ar_timestamp', $olduser, $newuser, $uid );
143152 $this->updateTable( 'logging', 'log_user_text', 'log_user', 'log_timestamp', $olduser, $newuser, $uid );
@@ -145,7 +154,17 @@
146155 $this->updateTable( 'filearchive', 'fa_user_text','fa_user', 'fa_timestamp', $olduser, $newuser, $uid );
147156 }
148157
149 - public function updateTable( $table,$usernamefield,$useridfield,$timestampfield,$olduser,$newuser,$uid ) {
 158+ /**
 159+ * @param $table
 160+ * @param $usernamefield
 161+ * @param $useridfield
 162+ * @param $timestampfield
 163+ * @param $olduser User
 164+ * @param $newuser User
 165+ * @param $uid
 166+ * @return int
 167+ */
 168+ public function updateTable( $table, $usernamefield, $useridfield, $timestampfield, $olduser, $newuser, $uid ) {
150169 $dbw = wfGetDB( DB_MASTER );
151170
152171 $contribs = $dbw->selectField( $table, 'count(*)',
@@ -199,8 +218,7 @@
200219 if ( $success ) {
201220 $rowsDone = $dbw->affectedRows();
202221 $dbw->commit();
203 - }
204 - else {
 222+ } else {
205223 print "Problem with the update, rolling back and exiting\n";
206224 $dbw->rollback();
207225 exit(1);

Status & tagging log