r107737 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107736‎ | r107737 | r107738 >
Date:20:42, 31 December 2011
Author:johnduhart
Status:ok
Tags:
Comment:
Followup r107710, Fixed silly mistakes
Modified paths:
  • /trunk/extensions/ServerAdminLog/ServerAdminLog.i18n.php (modified) (history)
  • /trunk/extensions/ServerAdminLog/ServerAdminLogChannel.php (modified) (history)
  • /trunk/extensions/ServerAdminLog/ServerAdminLogEntryPager.php (modified) (history)
  • /trunk/extensions/ServerAdminLog/tables.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/ServerAdminLog/ServerAdminLogChannel.php
@@ -13,7 +13,7 @@
1414 protected $id = 0;
1515
1616 /**
17 - * Chanel code
 17+ * Channel code
1818 *
1919 * @var string
2020 */
Index: trunk/extensions/ServerAdminLog/ServerAdminLog.i18n.php
@@ -28,5 +28,6 @@
2929
3030 // Special:AdminLog
3131 'adminlog' => 'Title at the top of [[Special:AdminLog]]',
32 - 'serveradminlog-invalidchannel' => 'Title of the page in the '
 32+ 'serveradminlog-invalidchannel' => 'Title of the page when an invalid channel is passed',
 33+ 'serveradminlog-invalidchannel-msg' => 'Message for when an invalid channel is passed',
3334 );
\ No newline at end of file
Index: trunk/extensions/ServerAdminLog/ServerAdminLogEntryPager.php
@@ -40,7 +40,7 @@
4141 $user = Linker::link( $userPage, htmlspecialchars( $userPage->getText() ) );
4242 }
4343
44 - // Link to the chanel name if the column is there
 44+ // Link to the channel name if the column is there
4545 if ( isset( $row->salc_name ) ) {
4646 $chanTitle = SpecialPage::getTitleFor( 'AdminLog', $row->salc_code );
4747 $channel = Linker::link( $chanTitle, htmlspecialchars( $row->salc_name ) );
Index: trunk/extensions/ServerAdminLog/tables.sql
@@ -1,7 +1,7 @@
22 -- Channel definition table
33 CREATE TABLE /*_*/sal_channel (
44 salc_id int(10) unsigned NOT NULL AUTO_INCREMENT,
5 - -- Code to access the chanel by
 5+ -- Code to access the channel by
66 salc_code varbinary(255) NOT NULL,
77 -- Human readable name
88 salc_name varbinary(255) NOT NULL,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107710Comitting new extension, ServerAdminLog. Meant as a replacement for the [[wik...johnduhart05:51, 31 December 2011

Status & tagging log