r107726 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107725‎ | r107726 | r107727 >
Date:17:55, 31 December 2011
Author:jeroendedauw
Status:ok
Tags:
Comment:
follow up to r107700
Modified paths:
  • /trunk/extensions/Maps/includes/manipulations/Maps_ParamGeoService.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/includes/manipulations/Maps_ParamGeoService.php
@@ -58,7 +58,9 @@
5959 if ( $value === '' || !array_key_exists( $value, MapsGeocoders::$registeredGeocoders ) ) {
6060 if ( !$validatedDefault ) {
6161 if ( !array_key_exists( $egMapsDefaultGeoService, MapsGeocoders::$registeredGeocoders ) ) {
62 - $egMapsDefaultGeoService = array_shift( array_keys( MapsGeocoders::$registeredGeocoders ) );
 62+ $geoServices = array_keys( MapsGeocoders::$registeredGeocoders );
 63+ $egMapsDefaultGeoService = array_shift( $geoServices );
 64+
6365 if ( is_null( $egMapsDefaultGeoService ) ) {
6466 throw new Exception( 'Tried to geocode while there are no geocoders available at ' . __METHOD__ );
6567 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107700dcos++jeroendedauw03:46, 31 December 2011

Status & tagging log