r107707 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107706‎ | r107707 | r107708 >
Date:04:27, 31 December 2011
Author:jeroendedauw
Status:ok
Tags:
Comment:
fix bug
Modified paths:
  • /trunk/extensions/SemanticMaps/includes/SM_AreaValueDescription.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/services/GoogleMaps3/SM_GoogleMaps3.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/services/OpenLayers/SM_OpenLayers.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/services/OpenLayers/SM_OpenLayersFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/services/YahooMaps/SM_YahooMaps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/includes/services/GoogleMaps3/SM_GoogleMaps3.php
@@ -1,7 +1,7 @@
22 <?php
33
44 /**
5 - * This groupe contains all Google Maps v3 related files of the Semantic Maps extension.
 5+ * This group contains all Google Maps v3 related files of the Semantic Maps extension.
66 *
77 * @defgroup SMGoogleMaps3 Google Maps v3
88 * @ingroup SMGoogleMaps3
Index: trunk/extensions/SemanticMaps/includes/services/YahooMaps/SM_YahooMaps.php
@@ -1,7 +1,7 @@
22 <?php
33
44 /**
5 - * This groupe contains all Yahoo! Maps related files of the Semantic Maps extension.
 5+ * This group contains all Yahoo! Maps related files of the Semantic Maps extension.
66 *
77 * @defgroup SMYahooMaps Yahoo! Maps
88 * @ingroup SemanticMaps
@@ -13,7 +13,8 @@
1414 * @file SM_YahooMaps.php
1515 * @ingroup SMYahooMaps
1616 *
17 - * @author Jeroen De Dauw
 17+ * @licence GNU GPL v3
 18+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
1819 */
1920
2021 if ( !defined( 'MEDIAWIKI' ) ) {
Index: trunk/extensions/SemanticMaps/includes/services/OpenLayers/SM_OpenLayers.php
@@ -1,7 +1,7 @@
22 <?php
33
44 /**
5 - * This groupe contains all OpenLayers related files of the Semantic Maps extension.
 5+ * This group contains all OpenLayers related files of the Semantic Maps extension.
66 *
77 * @defgroup SMOpenLayers OpenLayers
88 * @ingroup SemanticMaps
@@ -13,7 +13,8 @@
1414 * @file SM_OpenLayers.php
1515 * @ingroup SMOpenLayers
1616 *
17 - * @author Jeroen De Dauw
 17+ * @licence GNU GPL v3
 18+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
1819 */
1920
2021 if ( !defined( 'MEDIAWIKI' ) ) {
Index: trunk/extensions/SemanticMaps/includes/services/OpenLayers/SM_OpenLayersFormInput.php
@@ -5,8 +5,9 @@
66 *
77 * @file SM_OpenLayersFormInput.php
88 * @ingroup SMOpenLayers
9 - *
10 - * @author Jeroen De Dauw
 9+ *
 10+ * @licence GNU GPL v3
 11+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
1112 */
1213 class SMOpenLayersFormInput extends SMFormInput {
1314
Index: trunk/extensions/SemanticMaps/includes/SM_AreaValueDescription.php
@@ -68,8 +68,7 @@
6969 */
7070 public function getQueryString( $asValue = false ) {
7171 if ( $this->getDataItem() !== null ) {
72 - // FIXME
73 - $queryString = SMWDataValueFactory::newDataItemValue( $this->getDataItem() )->getWikiValue();
 72+ $queryString = SMWDataValueFactory::newDataItemValue( $this->getDataItem(), $this->m_property )->getWikiValue();
7473 return $asValue ? $queryString : "[[$queryString]]";
7574 } else {
7675 return $asValue ? '+' : '';

Status & tagging log