r107699 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107698‎ | r107699 | r107700 >
Date:03:38, 31 December 2011
Author:jeroendedauw
Status:ok
Tags:
Comment:
typo fixes and docs++
Modified paths:
  • /trunk/extensions/Contest/includes/Contest.class.php (modified) (history)
  • /trunk/extensions/Contest/includes/ContestContestant.php (modified) (history)
  • /trunk/extensions/Contest/includes/ContestDBObject.php (modified) (history)
  • /trunk/extensions/Contest/specials/SpecialContest.php (modified) (history)
  • /trunk/extensions/Contest/specials/SpecialContestPage.php (modified) (history)
  • /trunk/extensions/Contest/specials/SpecialContestSignup.php (modified) (history)
  • /trunk/extensions/Contest/specials/SpecialContestWelcome.php (modified) (history)
  • /trunk/extensions/Contest/specials/SpecialContests.php (modified) (history)
  • /trunk/extensions/Contest/specials/SpecialEditContest.php (modified) (history)
  • /trunk/extensions/Contest/specials/SpecialMyContests.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Contest/specials/SpecialMyContests.php
@@ -29,7 +29,7 @@
3030 *
3131 * @since 0.1
3232 *
33 - * @param string $arg
 33+ * @param string $subPage
3434 */
3535 public function execute( $subPage ) {
3636 $subPage = str_replace( '_', ' ', $subPage );
@@ -55,7 +55,7 @@
5656 /**
5757 * On regular page view, ie no submission and no sub-page,
5858 * display a list of all contests the user is participating in,
59 - * or in case there is only one, redirect them to the submissiom
 59+ * or in case there is only one, redirect them to the submission
6060 * UI of it.
6161 *
6262 * @since 0.1
@@ -330,6 +330,8 @@
331331 *
332332 * @since 0.1
333333 *
 334+ * @param array $data
 335+ *
334336 * @return true|array
335337 */
336338 public function handleSubmission( array $data ) {
@@ -381,6 +383,8 @@
382384 * @since 0.1
383385 *
384386 * @param ContestContestant $contest
 387+ *
 388+ * @return array
385389 */
386390 protected function getFormFields( ContestContestant $contestant ) {
387391 $fields = array();
@@ -546,7 +550,7 @@
547551 }
548552
549553 /**
550 - * HTMLForm field validation-callback for the submissiom field.
 554+ * HTMLForm field validation-callback for the submission field.
551555 * Warning: regexes used! o_O
552556 *
553557 * @since 0.1
Index: trunk/extensions/Contest/specials/SpecialContestWelcome.php
@@ -27,7 +27,7 @@
2828 *
2929 * @since 0.1
3030 *
31 - * @param string $arg
 31+ * @param string $subPage
3232 */
3333 public function execute( $subPage ) {
3434 $subPage = str_replace( '_', ' ', $subPage );
Index: trunk/extensions/Contest/specials/SpecialContestPage.php
@@ -43,7 +43,7 @@
4444 *
4545 * @since 0.1
4646 *
47 - * @param string $arg
 47+ * @param string $subPage
4848 */
4949 public function execute( $subPage ) {
5050 $this->subPage = $subPage;
@@ -94,6 +94,7 @@
9595 * @since 0.1
9696 *
9797 * @param string $message
 98+ * @param string $subst
9899 */
99100 protected function showSuccess( $message, $subst = '' ) {
100101 $this->getOutput()->addHTML(
Index: trunk/extensions/Contest/specials/SpecialContest.php
@@ -27,7 +27,7 @@
2828 *
2929 * @since 0.1
3030 *
31 - * @param string $arg
 31+ * @param string $subPage
3232 */
3333 public function execute( $subPage ) {
3434 $subPage = str_replace( '_', ' ', $subPage );
Index: trunk/extensions/Contest/specials/SpecialContests.php
@@ -49,7 +49,7 @@
5050 *
5151 * @since 0.1
5252 *
53 - * @param string $arg
 53+ * @param string $subPage
5454 */
5555 public function execute( $subPage ) {
5656 $subPage = str_replace( '_', ' ', $subPage );
Index: trunk/extensions/Contest/specials/SpecialContestSignup.php
@@ -27,7 +27,7 @@
2828 *
2929 * @since 0.1
3030 *
31 - * @param string $arg
 31+ * @param string $subPage
3232 */
3333 public function execute( $subPage ) {
3434 $subPage = str_replace( '_', ' ', $subPage );
@@ -59,6 +59,8 @@
6060 *
6161 * @since 0.1
6262 *
 63+ * @param array $data
 64+ *
6365 * @return true|array
6466 */
6567 public function handleSubmission( array $data ) {
@@ -176,7 +178,7 @@
177179 $form->setSubmitText( wfMsg( 'contest-signup-submit' ) );
178180
179181 if( $form->show() ) {
180 - $this->showSucess( $contest );
 182+ $this->showSuccess( $contest );
181183 }
182184 else {
183185 $this->getOutput()->addModules( 'contest.special.signup' );
@@ -199,7 +201,7 @@
200202 *
201203 * @param Contest $contest
202204 */
203 - protected function showSucess( Contest $contest ) {
 205+ protected function showSuccess( Contest $contest ) {
204206 $url = SpecialPage::getTitleFor( 'MyContests', $contest->getField( 'name' ) )->getLocalURL( 'new' );
205207 $this->getOutput()->redirect( $url );
206208 }
Index: trunk/extensions/Contest/specials/SpecialEditContest.php
@@ -357,6 +357,7 @@
358358 * @since 0.1
359359 *
360360 * @param integer|null $challengeId
 361+ * @param boolean $isNewChallenge
361362 *
362363 * @return ContestChallenge
363364 */
Index: trunk/extensions/Contest/includes/ContestDBObject.php
@@ -148,7 +148,7 @@
149149 *
150150 * @since 0.1
151151 *
152 - * @param integere|null $id
 152+ * @param integer|null $id
153153 */
154154 public function setId( $id ) {
155155 return $this->setField( 'id', $id );
Index: trunk/extensions/Contest/includes/ContestContestant.php
@@ -179,7 +179,7 @@
180180 *
181181 * @since 0.1
182182 *
183 - * @param booolean $addEmptyItem
 183+ * @param boolean $addEmptyItem
184184 *
185185 * @return array
186186 */
@@ -466,7 +466,7 @@
467467 }
468468
469469 /**
470 - * Handles successfull user signup for a contest.
 470+ * Handles successful user signup for a contest.
471471 *
472472 * @since 0.1
473473 */
@@ -537,7 +537,7 @@
538538 }
539539
540540 /**
541 - * Update the vote count and avarage vote fields.
 541+ * Update the vote count and average vote fields.
542542 * This does not write the changes to the database,
543543 * if this is required, call writeToDB.
544544 *
Index: trunk/extensions/Contest/includes/Contest.class.php
@@ -221,6 +221,8 @@
222222 *
223223 * @since 0.1
224224 *
 225+ * @param boolean $forceLoad
 226+ *
225227 * @return array of ContestChallenge
226228 */
227229 public function getChallenges( $forceLoad = false ) {
@@ -249,6 +251,8 @@
250252 *
251253 * @since 0.1
252254 *
 255+ * @param boolean $forceLoad
 256+ *
253257 * @return array of ContestContestant
254258 */
255259 public function getContestants( $forceLoad = false ) {

Status & tagging log