r107696 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107695‎ | r107696 | r107697 >
Date:03:14, 31 December 2011
Author:grafzahl
Status:ok
Tags:
Comment:
Follow-up r107695: strict checking on override_ogg might be required
Modified paths:
  • /trunk/extensions/Score/Score.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Score/Score.body.php
@@ -346,7 +346,7 @@
347347 throw new ScoreException( wfMessage( 'score-novorbislink', $e->getMessage() ), 0, $e );
348348 }
349349 }
350 - if ( $options['override_ogg'] ) {
 350+ if ( $options['override_ogg'] !== false ) {
351351 try {
352352 $link .= $parser->recursiveTagParse( "[[File:{$options['override_ogg']}]]" );
353353 } catch ( Exception $e ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107695Allow overriding of generated OGG filesgrafzahl03:06, 31 December 2011

Status & tagging log