| Index: trunk/phase3/maintenance/runJobs.php |
| — | — | @@ -61,16 +61,18 @@ |
| 62 | 62 | $dbw = wfGetDB( DB_MASTER ); |
| 63 | 63 | $n = 0; |
| 64 | 64 | $conds = ''; |
| 65 | | - if ( $type !== false ) |
| | 65 | + if ( $type !== false ) { |
| 66 | 66 | $conds = "job_cmd = " . $dbw->addQuotes( $type ); |
| | 67 | + } |
| 67 | 68 | |
| 68 | 69 | while ( $dbw->selectField( 'job', 'job_id', $conds, 'runJobs.php' ) ) { |
| 69 | 70 | $offset = 0; |
| 70 | 71 | for ( ; ; ) { |
| 71 | 72 | $job = !$type ? Job::pop( $offset ) : Job::pop_type( $type ); |
| 72 | 73 | |
| 73 | | - if ( !$job ) |
| | 74 | + if ( !$job ) { |
| 74 | 75 | break; |
| | 76 | + } |
| 75 | 77 | |
| 76 | 78 | wfWaitForSlaves(); |
| 77 | 79 | $t = microtime( true ); |
| Index: trunk/phase3/maintenance/commandLine.inc |
| — | — | @@ -41,8 +41,9 @@ |
| 42 | 42 | * No help, it would just be misleading since it misses custom options |
| 43 | 43 | */ |
| 44 | 44 | protected function maybeHelp( $force = false ) { |
| 45 | | - if ( !$force ) |
| | 45 | + if ( !$force ) { |
| 46 | 46 | return; |
| | 47 | + } |
| 47 | 48 | parent::maybeHelp( true ); |
| 48 | 49 | } |
| 49 | 50 | |
| Index: trunk/phase3/includes/filerepo/backend/lockmanager/DBLockManager.php |
| — | — | @@ -206,7 +206,7 @@ |
| 207 | 207 | $votesLeft = count( $this->dbsByBucket[$bucket] ); // remaining DBs |
| 208 | 208 | $quorum = floor( $votesLeft/2 + 1 ); // simple majority |
| 209 | 209 | // Get votes for each DB, in order, until we have enough... |
| 210 | | - foreach ( $this->dbsByBucket[$bucket] as $index => $lockDb ) { |
| | 210 | + foreach ( $this->dbsByBucket[$bucket] as $lockDb ) { |
| 211 | 211 | // Check that DB is not *known* to be down |
| 212 | 212 | if ( $this->cacheCheckFailures( $lockDb ) ) { |
| 213 | 213 | try { |
| Index: trunk/phase3/includes/installer/Installer.php |
| — | — | @@ -1228,7 +1228,7 @@ |
| 1229 | 1229 | |
| 1230 | 1230 | /** |
| 1231 | 1231 | * Overridden by WebInstaller to provide lastPage parameters. |
| 1232 | | - * @param $page stirng |
| | 1232 | + * @param $page string |
| 1233 | 1233 | * @return string |
| 1234 | 1234 | */ |
| 1235 | 1235 | protected function getDocUrl( $page ) { |
| Index: trunk/phase3/includes/ChangesList.php |
| — | — | @@ -446,7 +446,7 @@ |
| 447 | 447 | |
| 448 | 448 | /** Inserts a rollback link |
| 449 | 449 | * |
| 450 | | - * @param $s |
| | 450 | + * @param $s string |
| 451 | 451 | * @param $rc RecentChange |
| 452 | 452 | */ |
| 453 | 453 | public function insertRollback( &$s, &$rc ) { |
| — | — | @@ -469,10 +469,9 @@ |
| 470 | 470 | } |
| 471 | 471 | |
| 472 | 472 | /** |
| 473 | | - * @param $s |
| | 473 | + * @param $s string |
| 474 | 474 | * @param $rc RecentChange |
| 475 | 475 | * @param $classes |
| 476 | | - * @return |
| 477 | 476 | */ |
| 478 | 477 | public function insertTags( &$s, &$rc, &$classes ) { |
| 479 | 478 | if ( empty($rc->mAttribs['ts_tags']) ) |