r107678 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107677‎ | r107678 | r107679 >
Date:00:19, 31 December 2011
Author:reedy
Status:ok
Tags:
Comment:
Change attributes to default to array

<small>(cause php sucks)</small>
Modified paths:
  • /trunk/extensions/LdapAuthentication/LdapAuthentication.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LdapAuthentication/LdapAuthentication.php
@@ -236,7 +236,7 @@
237237 * @param null $deref
238238 * @return resource
239239 */
240 - public static function ldap_search( $ldapconn, $basedn, $filter, $attributes=null, $attrsonly=null, $sizelimit=null, $timelimit=null, $deref=null ) {
 240+ public static function ldap_search( $ldapconn, $basedn, $filter, $attributes=array(), $attrsonly=null, $sizelimit=null, $timelimit=null, $deref=null ) {
241241 wfSuppressWarnings();
242242 $ret = ldap_search( $ldapconn, $basedn, $filter, $attributes, $attrsonly, $sizelimit, $timelimit, $deref );
243243 wfRestoreWarnings();
@@ -255,7 +255,7 @@
256256 * @param null $deref
257257 * @return resource
258258 */
259 - public static function ldap_read( $ldapconn, $basedn, $filter, $attributes=null, $attrsonly=null, $sizelimit=null, $timelimit=null, $deref=null ) {
 259+ public static function ldap_read( $ldapconn, $basedn, $filter, $attributes=array(), $attrsonly=null, $sizelimit=null, $timelimit=null, $deref=null ) {
260260 wfSuppressWarnings();
261261 $ret = ldap_read( $ldapconn, $basedn, $filter, $attributes, $attrsonly, $sizelimit, $timelimit, $deref );
262262 wfRestoreWarnings();
@@ -274,7 +274,7 @@
275275 * @param null $deref
276276 * @return \resource
277277 */
278 - public static function ldap_list( $ldapconn, $basedn, $filter, $attributes=null, $attrsonly=null, $sizelimit=null, $timelimit=null, $deref=null ) {
 278+ public static function ldap_list( $ldapconn, $basedn, $filter, $attributes=array(), $attrsonly=null, $sizelimit=null, $timelimit=null, $deref=null ) {
279279 wfSuppressWarnings();
280280 $ret = ldap_list( $ldapconn, $basedn, $filter, $attributes, $attrsonly, $sizelimit, $timelimit, $deref );
281281 wfRestoreWarnings();

Status & tagging log