r107652 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r107651‎ | r107652 | r107653 >
Date:20:15, 30 December 2011
Author:krinkle
Status:ok
Tags:
Comment:
[UploadWizard] Fix breakage caused by r107011
* r107011 removed the .url property that was redundant with the options/defaults object
* `$ ack ".url" -Q` reveals that ".url" only occurs once in UploadWizard JavaScript (the property has some other occurrences but those are not related to an mw.Api object)
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizardUploadInterface.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.UploadWizardUploadInterface.js
——@@ -74,7 +74,7 @@
7575 // interface "below".
7676 // XXX caution -- if the add file input changes size we won't match, unless we add some sort of event to catch this.
7777 _this.form = $j( '<form method="POST" encType="multipart/form-data" class="mwe-upwiz-form"></form>' )
78 - .attr( { action: _this.upload.api.url } )
 78+ .attr( { action: _this.upload.api.defaults.url } )
7979 .append( _this.visibleFilenameDiv )
8080 .append( _this.fileCtrlContainer
8181 .append( _this.$fileInputCtrl )

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107011[mediawiki.api] clean up...krinkle23:52, 21 December 2011

Status & tagging log