r107598 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107597‎ | r107598 | r107599 >
Date:20:56, 29 December 2011
Author:yaron
Status:deferred
Tags:
Comment:
Follow-up to r102365 - stricter comparators sometimes indirectly led to embedded RunQuery form displaying a 'this page does not use this form' warning
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormPrinter.php
@@ -1522,7 +1522,7 @@
15231523
15241524 // Add a warning in, if we're editing an existing page and that
15251525 // page appears to not have been created with this form.
1526 - if ( $this->mPageTitle->exists() && ( $existing_page_content !== '' ) && ! $source_page_matches_this_form ) {
 1526+ if ( !$is_query && $this->mPageTitle->exists() && ( $existing_page_content !== '' ) && ! $source_page_matches_this_form ) {
15271527 $form_text = "\t" . '<div class="warningbox">' . wfMsg( 'sf_formedit_formwarning', $this->mPageTitle->getFullURL() ) . "</div>\n<br clear=\"both\" />\n" . $form_text;
15281528 }
15291529

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102365strict comparators for empty stringsjeroendedauw02:25, 8 November 2011