r107583 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107582‎ | r107583 | r107584 >
Date:18:07, 29 December 2011
Author:platonides
Status:ok
Tags:
Comment:
Parameters are clearly reversed.
Modified paths:
  • /trunk/extensions/OpenStackManager/special/SpecialNovaAddress.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/special/SpecialNovaAddress.php
@@ -566,7 +566,7 @@
567567 if ( $success ) {
568568 $this->getOutput()->addWikiMsg( 'openstackmanager-addedhost', $hostname, $ip );
569569 } else {
570 - $this->getOutput()->addWikiMsg( 'openstackmanager-addhostfailed', $ip, $hostname );
 570+ $this->getOutput()->addWikiMsg( 'openstackmanager-addhostfailed', $hostname, $ip );
571571 }
572572 } elseif ( $hostbyip ) {
573573 # We need to add an associateddomain, if the associateddomain doesn't already exist
@@ -574,7 +574,7 @@
575575 if ( $success ) {
576576 $this->getOutput()->addWikiMsg( 'openstackmanager-addedhost', $hostname, $ip );
577577 } else {
578 - $this->getOutput()->addWikiMsg( 'openstackmanager-addhostfailed', $ip, $hostname );
 578+ $this->getOutput()->addWikiMsg( 'openstackmanager-addhostfailed', $hostname, $ip );
579579 }
580580 } else {
581581 # This is a new host entry
@@ -582,7 +582,7 @@
583583 if ( $host ) {
584584 $this->getOutput()->addWikiMsg( 'openstackmanager-addedhost', $hostname, $ip );
585585 } else {
586 - $this->getOutput()->addWikiMsg( 'openstackmanager-addhostfailed', $ip, $hostname );
 586+ $this->getOutput()->addWikiMsg( 'openstackmanager-addhostfailed', $hostname, $ip );
587587 }
588588 }
589589 $this->getOutput();

Status & tagging log