r107567 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107566‎ | r107567 | r107568 >
Date:13:08, 29 December 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Collection of small bugfixes
Modified paths:
  • /trunk/extensions/Translate/resources/ext.translate.quickedit.js (modified) (history)
  • /trunk/extensions/Translate/utils/MessageTable.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/MessageTable.php
@@ -126,13 +126,13 @@
127127 }
128128
129129 global $wgLang;
130 - $niceTitle = htmlspecialchars( $wgLang->truncate( $title->getPrefixedText(), - 30 ) );
 130+ $niceTitle = htmlspecialchars( $wgLang->truncate( $title->getPrefixedText(), -35 ) );
131131
132132 $linker = class_exists( 'DummyLinker' ) ? new DummyLinker() : new Linker();
133133 $tools['edit'] = $linker->link(
134134 $title,
135135 $niceTitle,
136 - TranslationEditPage::jsEdit( $title ),
 136+ TranslationEditPage::jsEdit( $title, $this->group->getId() ),
137137 array( 'action' => 'edit' ) + $this->editLinkParams,
138138 'known'
139139 );
@@ -145,7 +145,7 @@
146146 $extra = '<br />' . $optional;
147147 }
148148
149 - $leftColumn = $anchor . $tools['edit'] . $this->getReviewButton( $m ) . $extra . $this->getReviewStatus( $m );
 149+ $leftColumn = $this->getReviewButton( $m ) . $anchor . $tools['edit'] . $extra . $this->getReviewStatus( $m );
150150
151151 if ( $this->reviewMode && $original !== $message ) {
152152 $output .= Xml::tags( 'tr', array( 'class' => 'orig' ),
Index: trunk/extensions/Translate/resources/ext.translate.quickedit.js
@@ -88,11 +88,11 @@
8989
9090 if ( mw.config.get( 'trlKeys' ) ) {
9191 form.find( '.mw-translate-next' ).click( function() {
92 - mw.translate.openNext( page );
 92+ mw.translate.openNext( page, group );
9393 } );
9494
9595 form.find( '.mw-translate-skip' ).click( function() {
96 - mw.translate.openNext( page );
 96+ mw.translate.openNext( page, group );
9797 dialog.dialog( 'close' );
9898 return false;
9999 } );
@@ -190,7 +190,7 @@
191191 return false;
192192 },
193193
194 - openNext: function( title ) {
 194+ openNext: function( title, group ) {
195195 var messages = mw.config.get( 'trlKeys' );
196196 var found = false, key, value;
197197
@@ -201,7 +201,7 @@
202202
203203 value = messages[key];
204204 if ( found ) {
205 - return mw.translate.openDialog( value );
 205+ return mw.translate.openDialog( value, group );
206206 } else if( value === title ) {
207207 found = true;
208208 }

Status & tagging log