r107549 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107548‎ | r107549 | r107550 >
Date:23:54, 28 December 2011
Author:krinkle
Status:ok
Tags:
Comment:
[Toolserver Intuition] Fix bug that caused infinite loop and eventually Fatal error on memory exhaustion.
* tracking cookie function uses the cookie function
* cookie function has a parameter to do or not set a tracking cookie along
* tracking cookie calls cookie function and passes NO_TRACK, default is DO_TRACK
* not a pretty structure but should work well, except if those two constants are set to the same value *facepalm*
Modified paths:
  • /trunk/tools/ToolserverI18N/Defines.php (modified) (history)

Diff [purge]

Index: trunk/tools/ToolserverI18N/Defines.php
@@ -15,4 +15,4 @@
1616 define( 'TSINT_HELP_CURRENT', null );
1717
1818 define( 'TSINT_COOKIE_TRACK', true );
19 -define( 'TSINT_COOKIE_NOTRACK', true );
 19+define( 'TSINT_COOKIE_NOTRACK', false );

Status & tagging log