r107512 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107511‎ | r107512 | r107513 >
Date:19:31, 28 December 2011
Author:kaldari
Status:ok
Tags:fundraising 
Comment:
slightly more accurate comment
Modified paths:
  • /trunk/extensions/LandingCheck/SpecialLandingCheck.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LandingCheck/SpecialLandingCheck.php
@@ -148,14 +148,12 @@
149149 /**
150150 * Construct new query string for tracking
151151 *
152 - * NB that both 'language' and 'uselang' get set to
 152+ * Note that both 'language' and 'uselang' get set to
153153 * $wgRequest->getVal( 'language', 'en')
154154 * This is wacky, yet by design! This is a unique oddity to fundraising
155 - * stuff, but CentralNotice converts the 'uselang' parameter to 'language',
156 - * so when a user clicks on a banner from CentralNotice which sends them
157 - * to Special:LandingCheck, it has already munged 'uselang' into 'language'.
158 - * Ultimately, this is something that should probably be rectified in
159 - * CentralNotice. Until then, this is what we've got.
 155+ * stuff, but CentralNotice converts wgUserLanguage to 'language' rather than
 156+ * 'uselang'. Ultimately, this is something that should probably be rectified
 157+ * in CentralNotice. Until then, this is what we've got.
160158 */
161159 $tracking = wfArrayToCGI( array(
162160 'utm_source' => $wgRequest->getVal( 'utm_source' ),

Status & tagging log