r107509 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107508‎ | r107509 | r107510 >
Date:19:02, 28 December 2011
Author:maxsem
Status:ok
Tags:
Comment:
WS, message fixes
Modified paths:
  • /trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php (modified) (history)
  • /trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php
@@ -49,8 +49,9 @@
5050 if ( is_array( $languagesForCountry ) ) {
5151 foreach( $languagesForCountry as $language ) {
5252 echo Html::element( 'h3',
53 - array( 'id' => 'lang_' . $language['language']),
54 - $languageNames[$language['language']]);
 53+ array( 'id' => 'lang_' . $language['language'] ),
 54+ $languageNames[$language['language']]
 55+ );
5556 echo Html::element( 'hr' );
5657 echo self::getSearchFormHtml( $language['language'] );
5758 }
@@ -61,12 +62,14 @@
6263 )
6364 );
6465 $output .= Html::element( 'option',
65 - array( 'value' => '' ),
66 - wfMsg( 'zero-rated-mobile-access-language-selection' ) );
 66+ array( 'value' => '' ),
 67+ wfMsg( 'zero-rated-mobile-access-language-selection' )
 68+ );
6769 foreach ( $languageNames as $languageCode => $languageName ) {
6870 $output .= Html::element( 'option',
69 - array( 'value' => '//' . $languageCode . '.m.wikipedia.org/' ),
70 - $languageName );
 71+ array( 'value' => '//' . $languageCode . '.m.wikipedia.org/' ),
 72+ $languageName
 73+ );
7174 }
7275 $output .= Html::closeElement( 'select' );
7376 echo $output;
Index: trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.i18n.php
@@ -13,7 +13,7 @@
1414
1515 // en translation
1616 $messages['en'] = array (
17 - 'zero-rated-mobile-access-desc' => 'Zero Rated Mobile Access extension provides features for mobile providers that provide free access',
 17+ 'zero-rated-mobile-access-desc' => 'Provides features for mobile providers that provide free access',
1818 'zero-rated-mobile-access-search' => 'Search',
1919 'zero-rated-mobile-access-language-options-wiki-page' => 'Language_options',
2020 'zero-rated-mobile-access-language-selection' => 'All languages',
@@ -26,7 +26,7 @@
2727 );
2828
2929 $messages['qqq'] = array(
30 - 'zero-rated-mobile-access-desc' => '{{Identical|Show}}',
 30+ 'zero-rated-mobile-access-desc' => '{{desc}}',
3131 'zero-rated-mobile-access-search' => 'Text for search action on the search button',
3232 'zero-rated-mobile-access-language-options-wiki-page' => 'The name of the wiki page to store the country language data',
3333 );
\ No newline at end of file

Status & tagging log