r107454 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107453‎ | r107454 | r107455 >
Date:00:26, 28 December 2011
Author:mah
Status:reverted
Tags:
Comment:
Fix Bug 33380 - Details of actions caught by a private filter should be private
Author: Nikola Kovacs

Related patch on r107451
Modified paths:
  • /trunk/extensions/AbuseFilter/AbuseFilter.class.php (modified) (history)
  • /trunk/extensions/AbuseFilter/AbuseFilter.i18n.php (modified) (history)
  • /trunk/extensions/AbuseFilter/AbuseFilter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AbuseFilter/AbuseFilter.php
@@ -141,7 +141,7 @@
142142 ),
143143 ) + $commonModuleInfo;
144144
145 -$wgAbuseFilterAvailableActions = array( 'flag', 'throttle', 'warn', 'disallow', 'blockautopromote', 'block', 'degroup', 'tag' );
 145+$wgAbuseFilterAvailableActions = array( 'flag', 'hidedetails', 'throttle', 'warn', 'disallow', 'blockautopromote', 'block', 'degroup', 'tag' );
146146
147147 $wgAbuseFilterConditionLimit = 1000;
148148
@@ -153,7 +153,7 @@
154154 // Abuse filter parser class
155155 $wgAbuseFilterParserClass = 'AbuseFilterParser';
156156
157 -$wgAbuseFilterRestrictedActions = array( 'block', 'degroup' );
 157+$wgAbuseFilterRestrictedActions = array( 'block', 'degroup', 'hidedetails' );
158158
159159 // UDP configuration
160160 $wgAbuseFilterUDPPrefix = 'abusefilter:';
Index: trunk/extensions/AbuseFilter/AbuseFilter.class.php
@@ -730,6 +730,7 @@
731731 $thisLog['afl_filter'] = $filter;
732732 $thisLog['afl_action'] = $action;
733733 $thisLog['afl_actions'] = implode( ',', $actions );
 734+ $thisLog['afl_deleted'] = in_array('hidedetails', $actions) ? 1 : 0;
734735
735736 // Don't log if we were only throttling.
736737 if ( $thisLog['afl_actions'] != 'throttle' ) {
@@ -935,7 +936,7 @@
936937 $vars, $rule_desc )
937938 {
938939 global $wgAbuseFilterCustomActionsHandlers;
939 -
 940+
940941 $display = '';
941942 switch ( $action ) {
942943 case 'disallow':
Index: trunk/extensions/AbuseFilter/AbuseFilter.i18n.php
@@ -193,6 +193,7 @@
194194 'abusefilter-edit-action-warn' => 'Trigger these actions after giving the user a warning',
195195 'abusefilter-edit-action-disallow' => 'Prevent the user from performing the action in question',
196196 'abusefilter-edit-action-flag' => 'Flag the edit in the abuse log',
 197+ 'abusefilter-edit-action-hidedetails' => 'Hide entries in the abuse log',
197198 'abusefilter-edit-action-blockautopromote' => "Revoke the user's autoconfirmed status",
198199 'abusefilter-edit-action-degroup' => 'Remove the user from all privileged groups',
199200 'abusefilter-edit-action-block' => 'Block the user and/or IP address from editing',
@@ -377,6 +378,7 @@
378379 'abusefilter-action-degroup' => 'Remove from groups',
379380 'abusefilter-action-rangeblock' => 'Range-block',
380381 'abusefilter-action-disallow' => 'Disallow',
 382+ 'abusefilter-action-hidedetails' => 'Hide log entries',
381383
382384 // Revert interface
383385 'abusefilter-revert-title' => 'Revert all changes by filter $1',
@@ -678,6 +680,7 @@
679681 'abusefilter-edit-action-warn' => 'Checkbox label for filter action.',
680682 'abusefilter-edit-action-disallow' => 'Checkbox label for filter action.',
681683 'abusefilter-edit-action-flag' => 'Checkbox label for filter action.',
 684+ 'abusefilter-edit-action-hidedetails' => 'Checkbox label for filter action.',
682685 'abusefilter-edit-action-blockautopromote' => 'Checkbox label for filter action.',
683686 'abusefilter-edit-action-degroup' => 'Checkbox label for filter action.',
684687 'abusefilter-edit-action-block' => 'Checkbox label for filter action.',

Follow-up revisions

RevisionCommit summaryAuthorDate
r107456Revert r107454 based on concerns raised by Prodego.mah00:48, 28 December 2011
r107472Fix half done revert of r107456 which was a revert of r107454raymond08:58, 28 December 2011
r107906Bug 33380 - Details of actions caught by a private filter should be private...mah17:29, 3 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107451Fix Bug 33390 - Examine page is visible for hidden log entries...mah23:35, 27 December 2011

Status & tagging log