r107427 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107426‎ | r107427 | r107428 >
Date:21:23, 27 December 2011
Author:catrope
Status:ok
Tags:
Comment:
1.18wmf1: MFT r107425
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5 (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.startup.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.startup.js
@@ -55,10 +55,11 @@
5656 && mw.util.getParamValue( 'printable' ) != 'yes'
5757 ) {
5858 // Collect categories for intersection tests
 59+ // Clone the arrays so we can safely modify them
5960 var categories = {
60 - 'include': mw.config.get( 'wgArticleFeedbackv5Categories', [] ),
61 - 'exclude': mw.config.get( 'wgArticleFeedbackv5BlacklistCategories', [] ),
62 - 'current': mw.config.get( 'wgCategories', [] )
 61+ 'include': [].concat( mw.config.get( 'wgArticleFeedbackv5Categories', [] ) ),
 62+ 'exclude': [].concat( mw.config.get( 'wgArticleFeedbackv5BlacklistCategories', [] ) ),
 63+ 'current': [].concat( mw.config.get( 'wgCategories', [] ) )
6364 };
6465
6566 var enable = false;
Property changes on: branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php
___________________________________________________________________
Modified: svn:mergeinfo
6667 Merged /trunk/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackv5.php:r107425
Property changes on: branches/wmf/1.18wmf1/extensions/ArticleFeedbackv5
___________________________________________________________________
Modified: svn:mergeinfo
6768 Merged /trunk/extensions/ArticleFeedbackv5:r107425

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107425Followup r105574 per CR: clone arrays from mw.config so we can modify them sa...catrope21:21, 27 December 2011

Status & tagging log