r107421 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107420‎ | r107421 | r107422 >
Date:20:56, 27 December 2011
Author:laner
Status:ok
Tags:
Comment:
Follow up to r107420. These calls shouldn't be static
Modified paths:
  • /trunk/extensions/LdapAuthentication/LdapAuthentication.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LdapAuthentication/LdapAuthentication.php
@@ -1545,10 +1545,10 @@
15461546 }
15471547 } else {
15481548 $this->printDebug( "Searching for the groups", NONSENSITIVE );
1549 - $this->userLDAPGroups = LdapAuthenticationPlugin::searchGroups( $usertopass );
 1549+ $this->userLDAPGroups = $this->searchGroups( $usertopass );
15501550
15511551 if ( $this->getConf( 'GroupSearchNestedGroups' ) ) {
1552 - $this->userLDAPGroups = LdapAuthenticationPlugin::searchNestedGroups( $this->userLDAPGroups );
 1552+ $this->userLDAPGroups = $this->searchNestedGroups( $this->userLDAPGroups );
15531553 $this->printDebug( "Got the following nested groups:", SENSITIVE, $this->userLDAPGroups["dn"] );
15541554 }
15551555 }
@@ -1556,7 +1556,7 @@
15571557 // Only find all groups if the user has any groups; otherwise, we are
15581558 // just wasting a search.
15591559 if ( $this->getConf( 'GroupsPrevail' ) && count( $this->userLDAPGroups ) != 0 ) {
1560 - $this->allLDAPGroups = LdapAuthenticationPlugin::searchGroups( '*' );
 1560+ $this->allLDAPGroups = $this->searchGroups( '*' );
15611561 }
15621562 }
15631563 }
@@ -1584,7 +1584,7 @@
15851585
15861586 $groupstosearch = array( "short" => array(), "dn" => array() );
15871587 foreach ( $groups["dn"] as $group ) {
1588 - $returnedgroups = LdapAuthenticationPlugin::searchGroups( $group );
 1588+ $returnedgroups = $this->searchGroups( $group );
15891589 $this->printDebug( "Group $group is in the following groups:", SENSITIVE, $returnedgroups["dn"] );
15901590 foreach ( $returnedgroups["dn"] as $searchme ) {
15911591 if ( in_array( $searchme, $searchedgroups["dn"] ) ) {
@@ -1610,7 +1610,7 @@
16111611
16121612 $searchedgroups = array_merge_recursive( $groups, $searchedgroups );
16131613
1614 - return LdapAuthenticationPlugin::searchNestedGroups( $groupstosearch, $searchedgroups );
 1614+ return $this->searchNestedGroups( $groupstosearch, $searchedgroups );
16151615 }
16161616
16171617 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r107409* Removed deprecated features...laner20:03, 27 December 2011
r107420Fix bad search and replace.laner20:52, 27 December 2011

Status & tagging log