r107404 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r107403‎ | r107404 | r107405 >
Date:18:31, 27 December 2011
Author:reedy
Status:ok
Tags:
Comment:
return false, not '' if no example

Reformat long string in a better way
Modified paths:
  • /trunk/extensions/MetricsReporting/ApiAnalyticsBase.php (modified) (history)
  • /trunk/extensions/MetricsReporting/metrics/EditorsByGeographyMetric.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MetricsReporting/ApiAnalyticsBase.php
@@ -348,8 +348,8 @@
349349 'data' => array(
350350 ' timeseries - returns ordered list of value pairs, one for each month within range',
351351 ' timeseriesindexed - like timeseries, but each month\'s value will be relative to oldest month\'s value which is always 100',
352 - ' percentagegrowthlastmonth, percentagegrowthlastyear, percentagegrowthfullperiod',
353 - ' - growth percentages are relative to oldest value (80->100=25%) although trivial, requesting these metrics through API ensures all clients use same calculation',
 352+ ' percentagegrowthlastmonth, percentagegrowthlastyear, percentagegrowthfullperiod - growth percentages are relative to oldest' .
 353+ ' value (80->100=25%) although trivial, requesting these metrics through API ensures all clients use same calculation',
354354 ),
355355 'reportlanguage' => 'Language code, used to expand region and country codes into region and country name',
356356 'selectregions' => array(
Index: trunk/extensions/MetricsReporting/metrics/EditorsByGeographyMetric.php
@@ -12,6 +12,6 @@
1313 }
1414
1515 protected function getExamples() {
16 - return "";
 16+ return false;
1717 }
18 -}
\ No newline at end of file
 18+}

Status & tagging log